Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update the PD client to adopt the latest fix #55234

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Aug 6, 2024

What problem does this PR solve?

Issue Number: close #53719.

Problem Summary:

What changed and how does it work?

Update to the latest release-8.1 PD client to adopt #53722.

Check List

Tests

  • Unit test
  • Integration test

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 6, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 6, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved labels Aug 6, 2024
@JmPotato
Copy link
Member Author

JmPotato commented Aug 6, 2024

/retest

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.1@891151b). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-8.1     #55234   +/-   ##
================================================
  Coverage               ?   71.1631%           
================================================
  Files                  ?       1466           
  Lines                  ?     422675           
  Branches               ?          0           
================================================
  Hits                   ?     300789           
  Misses                 ?     101365           
  Partials               ?      20521           
Flag Coverage Δ
unit 71.1631% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9656% <0.0000%> (?)
parser ∅ <0.0000%> (?)
br 41.3451% <0.0000%> (?)

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 7, 2024
Copy link

ti-chi-bot bot commented Aug 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-08-07 02:13:55.911039599 +0000 UTC m=+404565.778138687: ☑️ agreed by glorv.
  • 2024-08-07 02:19:26.5844696 +0000 UTC m=+404896.451568699: ☑️ agreed by nolouch.

@ti-chi-bot ti-chi-bot bot merged commit 370bd5a into pingcap:release-8.1 Aug 7, 2024
18 checks passed
@JmPotato JmPotato deleted the update_pd_client branch August 7, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants