Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka(ticdc): event router allow hard code topics and set the schema optional in the topic expression (#9755) #10355

Merged
merged 3 commits into from
Dec 27, 2023
Merged

kafka(ticdc): event router allow hard code topics and set the schema optional in the topic expression (#9755) #10355

merged 3 commits into from
Dec 27, 2023

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9755

What problem does this PR solve?

Issue Number: close #9763

What is changed and how it works?

  • schema is allowed to be optional in the topic expression.
  • allow user hard code the topic in the topic expression.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot added lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Dec 24, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 24, 2023
Merged
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Dec 26, 2023
@3AceShowHand
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 26, 2023
@3AceShowHand
Copy link
Contributor

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor

/retest

@3AceShowHand
Copy link
Contributor

/test cdc-integration-kafka-test

@ti-chi-bot ti-chi-bot bot merged commit ec1af7c into pingcap:release-6.5 Dec 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@3AceShowHand 3AceShowHand

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-chi-bot @3AceShowHand