Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kafka(ticdc): event router allow hard code topics and set the schema optional in the topic expression #9755

Merged
merged 15 commits into from
Sep 22, 2023
Merged

kafka(ticdc): event router allow hard code topics and set the schema optional in the topic expression #9755

merged 15 commits into from
Sep 22, 2023

Conversation

3AceShowHand
Copy link
Contributor

@3AceShowHand 3AceShowHand commented Sep 15, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9763

What is changed and how it works?

  • schema is allowed to be optional in the topic expression.
  • allow user hard code the topic in the topic expression.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 19, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2023
@3AceShowHand
Copy link
Contributor Author

/retest

1 similar comment
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/label ok-to-test

@ti-chi-bot ti-chi-bot bot added the ok-to-test Indicates a PR is ready to be tested. label Sep 22, 2023
@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ef7a972 into pingcap:master Sep 22, 2023
3 checks passed
@CharlesCheung96 CharlesCheung96 added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. and removed affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. labels Dec 24, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #10355.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 24, 2023
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: failed to apply #9755 on top of branch "release-7.5":

failed to git commit: exit status 1

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10356.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 24, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9755
278b7d2 
Signed-off-by: ti-chi-bot <[email protected]>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 24, 2023
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#9755
d772a35 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 24, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 27, 2023
@ti-chi-bot
kafka(ticdc): event router allow hard code topics and set the schema …
ec1af7c 
…optional in the topic expression (#9755) (#10355)

close #9763
@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: failed to apply #9755 on top of branch "release-7.5":

failed to git commit: exit status 1

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/cherrypick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: failed to apply #9755 on top of branch "release-7.5":

failed to git commit: exit status 1

In response to this:

/cherrypick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@3AceShowHand: failed to apply #9755 on top of branch "release-7.5":

failed to git commit: exit status 1

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@3AceShowHand
Copy link
Contributor Author

/need-cherry-pick release-7.5

@ti-chi-bot ti-chi-bot removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Feb 18, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Feb 22, 2024
@ti-chi-bot
kafka(ticdc): event router allow hard code topics and set the schema …
f5e2fd9 
…optional in the topic expression (#9755) (#10356)

close #9763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nongfushanquan nongfushanquan nongfushanquan approved these changes

@asddongmen asddongmen asddongmen approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

topic exression allows the schema part to be optional and accept hard code topic name
5 participants
@3AceShowHand @ti-chi-bot @asddongmen @nongfushanquan @CharlesCheung96