reset internal state of feedStateManager when shouldBeRunning is false #9893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
needs-cherry-pick-release-6.5
CharlesCheung96
force-pushed
the
fix-feed-state-manager
branch
from
09ac111 to
cf503b0
Compare
ti-chi-bot
bot
removed
the
size/M
|
/test all |
ti-chi-bot
bot
added
the
size/L
|
Could you please add a unit test case to cover it? |
asddongmen
reviewed
Oct 16, 2023
| @@ -416,12 +428,14 @@ func (m *feedStateManager) patchState(feedState model.FeedState) { | |||
| }) | |||
| } | |||
|
|
|||
| func (m *feedStateManager) cleanUpTaskPositions() { | |||
There was a problem hiding this comment.
Cleanup checkpointTs and resolvedTs before stopping, and it will be initialized when changefeed resumes.
asddongmen
approved these changes
Oct 16, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
nongfushanquan
approved these changes
Oct 16, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, nongfushanquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Oct 16, 2023
Signed-off-by: ti-chi-bot <[email protected]>
|
In response to a cherrypick label: new pull request created to branch |
ti-chi-bot
pushed a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Oct 16, 2023
Signed-off-by: ti-chi-bot <[email protected]>
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Oct 17, 2023
CharlesCheung96
added a commit
to ti-chi-bot/tiflow
that referenced
this pull request
Nov 2, 2023
sdojjy
pushed a commit
to sdojjy/tiflow
that referenced
this pull request
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #9892 #9650
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note