Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset internal state of feedStateManager when shouldBeRunning is false (#9893) #9904

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #9893

What problem does this PR solve?

Issue Number: close #9892

What is changed and how it works?

reset internal state of feedStateManager when shouldBeRunning is false

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`Fix a bug that changefeed fails directly when a warning is encountered after resume`.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 17, 2023
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-9893-to-release-6.5 branch from 00facb8 to cb256d7 Compare November 2, 2023 09:20
@CharlesCheung96
Copy link
Contributor

/retest

@sdojjy
Copy link
Member

sdojjy commented Nov 2, 2023

/retest-required

Copy link
Contributor

ti-chi-bot bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 2, 2023
@sdojjy
Copy link
Member

sdojjy commented Nov 2, 2023

/retest-required

@CharlesCheung96
Copy link
Contributor

/retest

@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-9893-to-release-6.5 branch from cb256d7 to 412704b Compare November 3, 2023 04:05
@CharlesCheung96 CharlesCheung96 force-pushed the cherry-pick-9893-to-release-6.5 branch from 412704b to 88f28a6 Compare November 3, 2023 04:06
@CharlesCheung96
Copy link
Contributor

/test all

@ti-chi-bot ti-chi-bot bot merged commit 390c6ff into pingcap:release-6.5 Nov 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants