Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat expired requests as list to fix indexing error #263

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Treat expired requests as list to fix indexing error #263

merged 2 commits into from
Sep 4, 2024

Conversation

djperrefort
Copy link
Member

Closes #262

Looks like a mismatch between the expected and returned type of get_most_recent_expired_request.

@Comeani can you double check this works for you?

@djperrefort djperrefort requested a review from Comeani August 30, 2024 14:59
Comeani
Comeani approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Comeani Comeani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and works for me when I run the commands on the cluster for a group that does not have active allocations.

@djperrefort djperrefort merged commit 143ee47 into main Sep 4, 2024
11 checks passed
@djperrefort djperrefort deleted the indexing_error branch September 4, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Comeani Comeani Comeani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

crc-usage: Indexing error when attempting to display most recent expired allocation request
2 participants
@djperrefort @Comeani