Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class #536

Merged
merged 14 commits into from
Nov 20, 2024

Merge branch 'main' into enhance-beacon-plugin-ios

cdb07d6
Select commit
Loading
Failed to load commit list.
Merged

iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class #536

Merge branch 'main' into enhance-beacon-plugin-ios
cdb07d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 20, 2024 in 0s

89.54% (-0.04%) compared to 35f98d7

View this Pull Request on Codecov

89.54% (-0.04%) compared to 35f98d7

Details

Codecov Report

Attention: Patch coverage is 82.96296% with 23 lines in your changes missing coverage. Please review.

Project coverage is 89.54%. Comparing base (35f98d7) to head (cdb07d6).

Files with missing lines Patch % Lines
...ugins/beacon/ios/Tests/BaseBeaconPluginTests.swift 82.65% 17 Missing ⚠️
ios/core/Sources/Types/Hooks/Hook.swift 68.75% 5 Missing ⚠️
plugins/beacon/ios/Sources/BaseBeaconPlugin.swift 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
- Coverage   89.57%   89.54%   -0.04%     
==========================================
  Files         331      331              
  Lines       19718    19830     +112     
  Branches     1949     1949              
==========================================
+ Hits        17663    17757      +94     
- Misses       2041     2059      +18     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features: