Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class #536

Merged
merged 14 commits into from
Nov 20, 2024

Merge branch 'main' into enhance-beacon-plugin-ios

cdb07d6
Select commit
Loading
Failed to load commit list.
Merged

iOS: Expose builldBeacon and cancelBeacon hooks inside of BaseBeaconPlugin and make BeaconPlugin open class #536

Merge branch 'main' into enhance-beacon-plugin-ios
cdb07d6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Nov 20, 2024 in 1s

82.96% of diff hit (target 89.57%)

View this Pull Request on Codecov

82.96% of diff hit (target 89.57%)

Annotations

Check warning on line 125 in ios/core/Sources/Types/Hooks/Hook.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

ios/core/Sources/Types/Hooks/Hook.swift#L125 

Added line #L125 was not covered by tests

Check warning on line 135 in ios/core/Sources/Types/Hooks/Hook.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

ios/core/Sources/Types/Hooks/Hook.swift#L135 

Added line #L135 was not covered by tests

Check warning on line 162 in ios/core/Sources/Types/Hooks/Hook.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

ios/core/Sources/Types/Hooks/Hook.swift#L162 

Added line #L162 was not covered by tests

Check warning on line 172 in ios/core/Sources/Types/Hooks/Hook.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

ios/core/Sources/Types/Hooks/Hook.swift#L172 

Added line #L172 was not covered by tests

Check warning on line 175 in ios/core/Sources/Types/Hooks/Hook.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

ios/core/Sources/Types/Hooks/Hook.swift#L175 

Added line #L175 was not covered by tests

Check warning on line 78 in plugins/beacon/ios/Sources/BaseBeaconPlugin.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Sources/BaseBeaconPlugin.swift#L78 

Added line #L78 was not covered by tests

Check warning on line 158 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L149-L158 

Added lines #L149 - L158 were not covered by tests

Check warning on line 165 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L164-L165 

Added lines #L164 - L165 were not covered by tests

Check warning on line 173 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L173 

Added line #L173 was not covered by tests

Check warning on line 203 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L203 

Added line #L203 was not covered by tests

Check warning on line 213 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L212-L213 

Added lines #L212 - L213 were not covered by tests

Check warning on line 224 in plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift

See this annotation in the file changed.

@codecov codecov / codecov/patch

plugins/beacon/ios/Tests/BaseBeaconPluginTests.swift#L224 

Added line #L224 was not covered by tests
View more details on Codecov