Server-side redirects for plone.app.redirector aliases

[JeffersonBledsoe]

Solves the Volto part of #4800. We're stripping the ++api++ if it is in a location change as we probably don't want to ever navigate directly to a page with ++api++ in it in the browser. Change the action causes the redux store to be correct, but the URL updating occurs earlier in the react-router stack, and so we also manually update the URL to not have ++api++ in it. History is still preserved correctly (++api++ pages aren't in the history stack but we can still go back and forwards normally).

The logic is currently mixed in with the blacklistRoutes middleware while I get some feedback, but this logic should probably be its own middleware for readability.

Note that the <Redirect> at

volto/src/components/theme/View/View.jsx

Line 217 in 87ff1f5

return <Redirect to={`${redirect}${this.props.location.search}`} />;

is causing SSR'd pages to send a 302 rather than forwarding on the status code sent by the REST API. Applying the changes mentioned in the react-router-dom docs for StaticRouting to pass the status along to the <StaticRouter> should resolve this and can be done in a follow-on PR.

[netlify]

✅ Deploy Preview for volto canceled.

Name	Link
🔨 Latest commit	5b17e9c
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/64e4cab01b989a000994dcab

[JeffersonBledsoe]

Hi @mamico I've incorporated your changes from #4821 into this PR and fixed some of the issues mentioned by @davisagli as well as resolved some other issues I had with client-side and SSR'd content while trialing your PR. I don't think either PR makes sense without the other really which is why I've merged them into 1.

[davisagli]

@JeffersonBledsoe This is the new one you opened today. Did you mean to close it?

[JeffersonBledsoe]

@davisagli Not sure what happened there, I didn't close it. I had a GitHub bug where i ended up with two branches of the same name which is why i created a second copy of this PR. Mind reviewing this one?

[cypress]

Passing run #6945 ↗︎

0

553

20

0

0

Details:

Merge branch 'master' into handle-api-redirect
Project: Volto	Commit: 5b17e9c3e4
Status: Passed	Duration: 14:30 💡
Started: Aug 22, 2023 2:51 PM	Ended: Aug 22, 2023 3:05 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[mamico]

@JeffersonBledsoe @djay @davisagli there are any news on this? thx.

[JeffersonBledsoe]

@mamico We’ve been running this in production for a while now, and while it’s mostly been okay, we’ve noticed some weird URLs appearing. I need to verify that this PR isn’t the cause before I’d feel comfortable merging it

[mamico]

@JeffersonBledsoe @djay @davisagli @sneridagh are there any updates on this? thx

[djay]

@mamico what we are seeing is that google search console is ending up indexing urls like

https://digitalnsw.pretagov.com.au/components/cards?expand=actions,breadcrumbs,navigation&expand.navigation.depth=2

(where there was an old url of https://digitalnsw.pretagov.com.au/demo-pages/cards)

it might not be change to blame though. We just haven't had the time yet to investigate where these are coming from.

[netlify]

❌ Deploy Preview for volto failed. Why did it fail? →

Name	Link
🔨 Latest commit	e623ad6
🔍 Latest deploy log	https://app.netlify.com/sites/volto/deploys/66467c351f6a9000081ba387

[netlify]

✅ Deploy Preview for plone-components canceled.

Name	Link
🔨 Latest commit	e623ad6
🔍 Latest deploy log	https://app.netlify.com/sites/plone-components/deploys/66467c356337f200089f947e

lots of changes since this review

[davisagli]

@sneridagh I think this is ready now. The fix is basically the same as Rob's from #5999 but it strips /++api++ from the redirect location if it is there.

[JeffersonBledsoe]

Thanks for finishing this!