-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address build issues occurring when building with Library Evolution support, Xcode 16 #133
Address build issues occurring when building with Library Evolution support, Xcode 16 #133
Conversation
Address build issues seen building for library evolution mode, Xcode 16 - i.e. `make build-for-library-evolution`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We actually had a library evolution CI action that was still on 15.4, so I've pushed an update for it to run against Xcode 16. If things go green I'll merge!
file: IssueContext.current?.filePath ?? filePath, | ||
line: IssueContext.current?.line ?? line | ||
) | ||
@unknown default: break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it's worth reporting issues from this branch? From a practical perspective I can't see this unknown branch ever hitting, though, so this should be OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely went back-and-forth about combining this with the nil
branch case somehow. I ultimately came to the same conclusion you did; unlikely to fire in practice.
Oh that makes sense 😄 Awesome. |
@stephencelis - if you're able to cut a new release and update some of the other Happy to help with the effort if useful ! |
@gemmakbarlow Done! https://github.com/pointfreeco/swift-issue-reporting/releases/tag/1.4.1 There should be no need to change our other libraries to receive the update. Just make sure you update your packages in your project so that the Package.resolved file pulls in the newer version and you should be good to go! Or you can explicitly depend on 1.4.1 in your package/project. |
Perfect, thanks for the tip and speedy replies. |
Address build issues seen building for library evolution mode, Xcode 16 - i.e. via
make build-for-library-evolution
.