Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol] Claim & Proof Account Management Interface MVP #243

Closed
9 tasks
Olshansk opened this issue Dec 5, 2023 · 4 comments
Closed
9 tasks

[Protocol] Claim & Proof Account Management Interface MVP #243

Olshansk opened this issue Dec 5, 2023 · 4 comments
Assignees
Labels
on-chain On-chain business logic protocol General core protocol related changes

Comments

@Olshansk
Copy link
Member

Olshansk commented Dec 5, 2023

Objective

Build the foundation for session account management: mint & burn w.r.t applications & supplies in the context of the claim & proof lifecycle.

Origin Document

This is a natural extension of the following tickets:

Goals

  • Decouple the Claim & Proof lifecycle from application/supplier mint & burn flow
  • Close the loop on the claim & proof lifecycle
  • Design a structure that makes it easy to implement, iterate on and experiment with different types of tokenomics

Deliverables

  • A single PR that defines a new interface (name TBD) that hooks into post-proof validation account management
  • A single PR that provides the first (basic) implementation of the above interface
  • A single PR that introduces the minimum viable number of on-chain parameters necessary for this implementation
  • Documentation detailing the importance of this interface and how it can be used/extended
  • A PR with at least 1 E2E test validating the results of its behaviour

Non-goals / Non-deliverables

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @bryanchriswhite @RawthiL

@Olshansk Olshansk added protocol General core protocol related changes on-chain On-chain business logic labels Dec 5, 2023
@Olshansk Olshansk added this to the Shannon Quality of Life milestone Dec 5, 2023
@Olshansk Olshansk self-assigned this Dec 5, 2023
@Olshansk Olshansk added this to Shannon Dec 5, 2023
@Olshansk Olshansk moved this to 🔖 Ready in Shannon Dec 5, 2023
@Olshansk
Copy link
Member Author

Olshansk commented Dec 7, 2023

As a quick update on this, the plan is to:

  1. Scaffold an accounting module
  2. Have the accounting module be dependent on other modules for access to state data
  3. The module will primarily be responsible for managing/updating parameters
  4. The module will expose functions (i.e. via expected_keeper) that can be called to do post-proof accounting.
  5. (4) enables decoupling of accounting and the claim & proof lifecycle, enabling experimentation, mocking and more

Rough Notes (for ref): https://www.notion.so/buildwithgrove/Olshansky-s-Diaries-79fd0008a15049c1b30ea47895649164?pvs=4#9ceaa6f511ab4fb7963f93e794e0736f

cc @RawthiL for visibility

@Olshansk
Copy link
Member Author

Olshansk commented Dec 7, 2023

I tried to run ignite scaffold module accounting --params compute_to_tokens_multiplier:uint but the module can't be prefixed with prefixed with acc.

@bryanchriswhite I'm going to go with economics but going to hold off on the scaffold PR until I get a 👍 in case you have a stronger opinion it.

Screenshot 2023-12-06 at 7 38 45 PM
Screenshot 2023-12-06 at 7 39 01 PM
Screenshot 2023-12-06 at 7 38 54 PM

@bryanchriswhite
Copy link
Contributor

@Olshansk I like economics the most out of those options. What do you think about "treasury"?

image

@Olshansk
Copy link
Member Author

tl;dr we're going with tokenomics

giphy

@Olshansk Olshansk moved this from 🔖 Ready to 🏗 In progress in Shannon Jan 8, 2024
@Olshansk Olshansk closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Shannon Feb 2, 2024
Olshansk added a commit that referenced this issue Feb 2, 2024
…burn) (#323)

Implement `SettleSessionAccounting` where emissions=burn.

- Issue: #243 

---

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
Co-authored-by: Bryan White <[email protected]>
okdas added a commit that referenced this issue Nov 14, 2024
…burn) (#323)

Implement `SettleSessionAccounting` where emissions=burn.

- Issue: #243 

---

Co-authored-by: Redouane Lakrache <[email protected]>
Co-authored-by: Dima Kniazev <[email protected]>
Co-authored-by: Bryan White <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic protocol General core protocol related changes
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants