Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scaffolded Tokenomics module #251

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Scaffolded Tokenomics module #251

merged 2 commits into from
Dec 8, 2023

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Dec 8, 2023

Summary

Human Summary

Ran the following command and nothing else.

ignite scaffold module tokenomics --params compute_to_tokens_multiplier:unit

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@Olshansk Olshansk added the protocol General core protocol related changes label Dec 8, 2023
@Olshansk Olshansk added this to the Shannon TestNet milestone Dec 8, 2023
@Olshansk Olshansk self-assigned this Dec 8, 2023
@Olshansk Olshansk changed the title [Tokenomics] Scaffolded tokenomics module Scaffolded Tokenomics module Dec 8, 2023
@Olshansk Olshansk merged commit 0cc971c into main Dec 8, 2023
9 checks passed
@Olshansk Olshansk deleted the issues/243/scaffold_tokenomics_module branch December 8, 2023 21:20
@Olshansk Olshansk added the tokenomics Token Economics - what else do you need? label Dec 8, 2023
@Olshansk Olshansk mentioned this pull request Dec 20, 2023
Merged
11 tasks
okdas pushed a commit that referenced this pull request Nov 14, 2024
@Olshansk
Scaffolded Tokenomics module (#251)
488c1df 
* Scaffolded tokenomics module
* Fix make go_lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

Assignees

@Olshansk Olshansk

Labels
protocol General core protocol related changes tokenomics Token Economics - what else do you need?
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Private TestNet
Development

Successfully merging this pull request may close these issues.
2 participants
@Olshansk @bryanchriswhite