Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Wrap errors by type not by sdkerrors import's Wrapf method. #422

Merged
merged 1 commit into from
Mar 12, 2024
Merged

[Cleanup] Wrap errors by type not by sdkerrors import's Wrapf method. #422

merged 1 commit into from
Mar 12, 2024

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Mar 12, 2024

Summary

As per #347 (comment) some sed magic to make a few adjustments.

:%s/sdkerrors\(\.Wrap[f?](\)\n*\s*\(.\+\),/\2\1/ge

Human Summary

Conform to wrapping errors the same everywhere.

AI Summary

reviewpad:summary

Issue

  • N/A

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@h5law h5law added the code health Cleans up some code label Mar 12, 2024
@h5law h5law added this to the Shannon Quality of Life milestone Mar 12, 2024
@h5law h5law self-assigned this Mar 12, 2024
@h5law h5law requested a review from bryanchriswhite March 12, 2024 13:09
@bryanchriswhite bryanchriswhite linked an issue Mar 12, 2024 that may be closed by this pull request
[Code Health] Simplify error object usage #347
Closed
5 tasks
bryanchriswhite
bryanchriswhite approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks! 😎

@bryanchriswhite
Copy link
Contributor

Fixes #347

@h5law h5law merged commit 9329a75 into main Mar 12, 2024
10 checks passed
bryanchriswhite added a commit that referenced this pull request Mar 22, 2024
@bryanchriswhite
Merge branch 'feat/proof-validation' into test/proof-integration
a262455 
* feat/proof-validation:
  Offline review of 406
  [LocalNet] Fix/localnet regenesis (#424)
  [CI] Delete validator pod if stuck during E2E test (#415)
  Fixing reletive link in documentation
  [Docs] Add code review guidelines & developer tips (#426)
  [Quick change] Bump default gas limit (#431)
  chore: Fix unit tests and ring client removal consideration
  chore: Remove pubkey client
  chore: Add missing change requests
  chore: Address review change requests
  Update pull_request_template.md
  Update pull_request_template.md
  [Cleanup] Wrap errors consistently via error types. (#422)
  [LocalNet] Allow to scale up actors (#414)
  [Test] Replace time waiting with message submission waiting (#418)
  Remove accidentally added config files (#420)
  fix: Ignore externally initiated transactions (#407)
  [Bug] Address go-routines leak (#410)
okdas pushed a commit that referenced this pull request Nov 14, 2024
[Cleanup] Wrap errors consistently via error types. (#422)
6cf94c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

Assignees

@h5law h5law

Labels
code health Cleans up some code
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Quality of Life
Development

Successfully merging this pull request may close these issues.

[Code Health] Simplify error object usage
2 participants
@h5law @bryanchriswhite