Handle session lock surfaces in visible_outputs_for_surface
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue with re-draw not being queued on initial surface commit until cursor is moved.
|
Added a commit to schedule a renderer when the session lock is created or destroyed, which also improves behavior in certain cases. |
Drakulix
reviewed
Nov 15, 2023
|
|
||
| for output in self.common.shell.outputs() { | ||
| self.backend | ||
| .schedule_render(&self.common.event_loop_handle, &output, None); |
There was a problem hiding this comment.
Seeing None here for the screencopy-sessions reminds me... how do we want to handle screencopy, if a session-lock is active?
I don't think we want to capture the lock-screen (do we??), so perhaps we should suspend them while the lock is active and never return a new frame?
Drakulix
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with re-draw not being queued on initial surface commit until cursor is moved.