Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle session lock surfaces in visible_outputs_for_surface #224

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Handle session lock surfaces in visible_outputs_for_surface #224

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b155b56
Handle session lock surfaces in `visible_outputs_for_surface`
ids1024 Nov 14, 2023
fd3bd0b
Schedule render when session lock is created/destroyed
ids1024 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/wayland/handlers/session_lock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,20 @@ impl SessionLockHandler for State {
ext_session_lock,
surfaces: HashMap::new(),
});

for output in self.common.shell.outputs() {
self.backend
.schedule_render(&self.common.event_loop_handle, &output, None);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing None here for the screencopy-sessions reminds me... how do we want to handle screencopy, if a session-lock is active?

I don't think we want to capture the lock-screen (do we??), so perhaps we should suspend them while the lock is active and never return a new frame?

}
}

fn unlock(&mut self) {
self.common.shell.session_lock = None;

for output in self.common.shell.outputs() {
self.backend
.schedule_render(&self.common.event_loop_handle, &output, None);
}
}

fn new_surface(&mut self, lock_surface: LockSurface, wl_output: WlOutput) {
Expand Down