Use a tracing subscriber for LSP logging

.github/workflows/test-linux.yml

@@ -51,4 +51,8 @@ jobs:
         run: cargo build
 
       - name: Run unit tests
-        run: cargo test
+        env:
+          AIR_LOG_LEVEL: trace
+        # `--nocapture` to see our own `tracing` logs
+        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
+        run: cargo test -- --nocapture --test-threads 1

.github/workflows/test-mac.yml

@@ -29,4 +29,8 @@ jobs:
         run: cargo build
 
       - name: Run unit tests
-        run: cargo test
+        env:
+          AIR_LOG_LEVEL: trace
+        # `--nocapture` to see our own `tracing` logs
+        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
+        run: cargo test -- --nocapture --test-threads 1

.github/workflows/test-windows.yml

@@ -29,4 +29,8 @@ jobs:
         run: cargo build
 
       - name: Run unit tests
-        run: cargo test
+        env:
+          AIR_LOG_LEVEL: trace
+        # `--nocapture` to see our own `tracing` logs
+        # `--test-threads 1` to ensure `tracing` logs aren't interleaved
+        run: cargo test -- --nocapture --test-threads 1

Cargo.toml

@@ -55,19 +55,21 @@ ignore = "0.4.23"
 insta = "1.40.0"
 itertools = "0.13.0"
 line-index = "0.1.2"
-log = "0.4.22"
 memchr = "2.7.4"
 path-absolutize = "3.1.1"
 proc-macro2 = "1.0.86"
 serde = { version = "1.0.215", features = ["derive"] }
 serde_json = "1.0.132"
 struct-field-names-as-array = "0.3.0"
+strum = "0.26"
+time = "0.3.37"
 thiserror = "2.0.5"
 tokio = { version = "1.41.1" }
 tokio-util = "0.7.12"
 # For https://github.com/ebkalderon/tower-lsp/pull/428
 tower-lsp = { git = "https://github.com/lionel-/tower-lsp", branch = "bugfix/patches" }
 tracing = { version = "0.1.40", default-features = false, features = ["std"] }
+tracing-subscriber = "0.3.19"
 tree-sitter = "0.23.0"
 tree-sitter-r = { git = "https://github.com/r-lib/tree-sitter-r", rev = "a0d3e3307489c3ca54da8c7b5b4e0c5f5fd6953a" }
 triomphe = "0.1.14"

crates/lsp/Cargo.toml

@@ -25,14 +25,16 @@ dissimilar.workspace = true
 futures.workspace = true
 itertools.workspace = true
 line_ending.workspace = true
-log.workspace = true
 memchr.workspace = true
 serde.workspace = true
 serde_json.workspace = true
 struct-field-names-as-array.workspace = true
+strum = { workspace = true, features = ["derive"] }
+time = { workspace = true }
 tokio = { workspace = true, features = ["full"] }
 tower-lsp.workspace = true
 tracing.workspace = true
+tracing-subscriber = { workspace = true, features = ["ansi", "local-time"] }
 tree-sitter.workspace = true
 tree-sitter-r.workspace = true
 triomphe.workspace = true

crates/lsp/src/config.rs

@@ -95,7 +95,7 @@ impl From<VscDocumentConfig> for DocumentConfig {
                 if var == "tabSize" {
                     x.tab_size
                 } else {
-                    log::warn!("Unknown indent alias {var}, using default");
+                    tracing::warn!("Unknown indent alias {var}, using default");
                     2
                 }
             }

crates/lsp/src/encoding.rs

@@ -34,7 +34,7 @@ fn convert_character_from_utf16_to_utf8(x: &str, character: usize) -> usize {
         }
     }
 
-    log::error!("Failed to locate UTF-16 offset of {character}. Line: '{x}'.");
+    tracing::error!("Failed to locate UTF-16 offset of {character}. Line: '{x}'.");
     0
 }
 
@@ -52,7 +52,7 @@ fn convert_character_from_utf8_to_utf16(x: &str, character: usize) -> usize {
         Some(x) => x.encode_utf16().count(),
         None => {
             let n = x.len();
-            log::error!(
+            tracing::error!(
                 "Tried to take UTF-8 character {character}, but only {n} characters exist. Line: '{x}'."
             );
             0