Add a few more OpenRPC methods for rstudioapi shims #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test this out, together with posit-dev/positron#2593, try: rstudioapi::sendToConsole("1 + 1")
rstudioapi::sendToConsole("1 + 1", focus = FALSE)
rstudioapi::sendToConsole("1 + ")
rstudioapi::sendToConsole("lm(mpg ~ ., data = mtcars)")
some_code <- c("library(tidyverse)", "arrange(mtcars, mpg)")
rstudioapi::sendToConsole(some_code, focus = FALSE)
rstudioapi::documentNew(some_code)
rstudioapi::documentNew("SELECT * FROM 1", type = "sql") |
juliasilge
commented
Apr 1, 2024
| language_id: String::from("r"), | ||
| code: RObject::view(code).try_into()?, | ||
| focus: RObject::view(focus).try_into()?, | ||
| allow_incomplete: false, |
There was a problem hiding this comment.
Using false here to be consistent with the RStudio behavior for rstudioapi::sendToConsole("1 + ")
|
Addresses posit-dev/positron#2441 because I figured out what to do. Short answer: the rstudioapi shims must have exactly the function signatures as from this file. |
DavisVaughan
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#1312 with what I hope 🤞 are the last Public Beta rstudioapi shims
Goes along with posit-dev/positron#2593