-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a few more OpenRPC methods for rstudioapi shims #2593
Conversation
const uri = await this.documents.createDocumentData({ | ||
content: contents, language: languageId | ||
}); | ||
const opts: TextEditorOpenOptions = { preview: true }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we address #2438, we can pass a Range
(i.e. two Position
objects) in here in the TextEditorOpenOptions
.
// TODO: Return a document ID | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For us to address with #2571
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
TODO:
|
Signed-off-by: Julia Silge <[email protected]>
Signed-off-by: Julia Silge <[email protected]>
Intent
Addresses #1312 with what I hope 🤞 are the last Public Beta rstudioapi shims
Goes along with posit-dev/ark#286
Approach
Chugging along with more rstudioapi shims, as before 🚂
QA Notes
To test this out, together with posit-dev/ark#286, try: