Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow introduction of ColumnDisplayType enum in data explorer comm #293

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Apr 3, 2024

Part of posit-dev/positron#2617, adds new top-level enum and renames things accordingly. The summary stats structs aren't used and can be disregarded here for now.

@wesm
Copy link
Contributor Author

wesm commented Apr 3, 2024

@jmcphers do you know what this test failure is caused by?

test test_kernel ... FAILED

failures:

---- test_kernel stdout ----
thread 'test_kernel' panicked at crates/amalthea/tests/client.rs:437:13:
assertion failed: !comms.contains_key(comm_id)
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    test_kernel

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.51s

error: test failed, to rerun pass `-p amalthea --test client`

@wesm wesm requested a review from jmcphers April 3, 2024 01:27
@wesm
Copy link
Contributor Author

wesm commented Apr 3, 2024

Re-running the build just worked -- is that failure a known flake? If not should create an issue about it. cc also @lionel-

@wesm wesm force-pushed the feature/de-column-summary-updates branch from 05140b9 to 5a409d0 Compare April 3, 2024 22:57
@wesm wesm merged commit 1a7365f into main Apr 3, 2024
1 check passed
@wesm wesm deleted the feature/de-column-summary-updates branch April 3, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant