Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine summary stats backend RPCs for data explorer, add Python implementation and basic scaffolding #2617

Merged
merged 5 commits into from
Apr 3, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Apr 3, 2024

In short:

  • Extracts ColumnSchema.type_display enum into a new top-level ColumnDisplayType enum
  • Fixes generate-comms.ts to handle enums in components.schemas
  • Deletes some dead (?) type alias code in generate-comms.ts that wasn't needed anywhere that I could tell. I made sure Amalthea followed this
  • Added interfaces for each type of summary stats to match what we want to show in the UI
  • Added basic implementations for Python
  • Did minimal kludge to show the numeric stats in the UI after clicking a bit to get React to re-render (not sure how to handle async calls there)

I concluded that the backend will need to send numeric summary stats as numbers so the UI can normalize formatting, so I can change the numeric summary stats struct to return numbers whenever we are ready to take responsibility for this formatting in the UI. See also related #2614

See downstream posit-dev/ark#293

@wesm wesm force-pushed the feature/de-summary-stats branch from cb28e99 to 351ccbb Compare April 3, 2024 15:03
@wesm wesm merged commit 126b5a4 into main Apr 3, 2024
23 checks passed
@wesm wesm deleted the feature/de-summary-stats branch April 3, 2024 21:09
@wesm
Copy link
Contributor Author

wesm commented Apr 3, 2024

Merged this to keep things moving so Brian can pick up these changes. Any feedback here I can take into account in the next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant