Data Explorer: Add support for formatting options #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfalbel
force-pushed
the
feature/formatting-options
branch
from
f6dbfa4 to
21c5df9
Compare
lionel-
reviewed
Jun 11, 2024
Co-authored-by: Lionel Henry <[email protected]>
This was referenced Jun 12, 2024
Merged
dfalbel
added a commit
that referenced
this pull request
Jun 12, 2024
dfalbel
added a commit
that referenced
this pull request
Jun 18, 2024
dfalbel
added a commit
that referenced
this pull request
Jun 20, 2024
* Refactor summary stats + add support for date stats * Add datetime support * Port formatting from the format options PR (#382) * Do not use `[` from hash maps as they can `panic!` if the key is not present. * Improve comment + rm `r_stats[]` call * remove final period * Apply suggestions from code review Co-authored-by: Lionel Henry <[email protected]> * Extract as own function * Simplify code to avoid using macro * Just `try_into()` to cast into strings. * Use option strings to follow the updated RPC contract. --------- Co-authored-by: Lionel Henry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses posit-dev/positron#3211 and posit-dev/positron#2339
Branched off #376