Format VSCode extension code with Prettier #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotNomad
force-pushed
the
dotnomad/vscode-prettier
branch
from
1971121 to
04d027d
Compare
dotNomad
force-pushed
the
dotnomad/vscode-prettier
branch
2 times, most recently
from
fcd3533 to
c445189
Compare
dotNomad
requested review from
kgartland-rstudio,
mmarchetti,
sagerb and
tdstein
as code owners
sagerb
changed the base branch from
main
to
prettier-introduction-integration-branch
sagerb
merged commit b1848ee
into
prettier-introduction-integration-branch
34 of 42 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up Prettier to format our VSCode extension. #1180 contains the actual formatting changes which will be merged into this to get CI passing - keeping it separate for now for easy review.
Intent
Part of #1030
Type of Change
Approach
eslint-config-prettierto ensure that Prettier and ESLint play nicely togetherjust vscode check-formatin the same GitHub workflows that run the linting