Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format web code with Prettier #1187

Merged

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Mar 20, 2024

A copy of the work that was done with Prettier for the VSCode extension.

This sets up Prettier, the ESLint Prettier extension, the Just commands, adds the linting and formatting checks to the Lint GitHub workflow, and prepares everything for formatting.

Intent

Part of #1030

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

Approach

Same approach as #1178 and #1184

@dotNomad dotNomad marked this pull request as ready for review March 21, 2024 00:03
@dotNomad
Copy link
Collaborator Author

This will fail until #1189 and the ESLint follow-up are ready.

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from dotnomad/iso-lint-vscode to prettier-introduction-integration-branch March 21, 2024 18:11
@sagerb sagerb merged commit 36a3bda into prettier-introduction-integration-branch Mar 21, 2024
21 of 22 checks passed
@sagerb sagerb deleted the dotnomad/web-prettier branch March 21, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants