Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run prettier format on web code #1189

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

dotNomad
Copy link
Collaborator

@dotNomad dotNomad commented Mar 21, 2024

Direct follow-up to #1187 and #1188.

This PR actually runs the formatting on the web director with just web format.

Intent

Part of #1030

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

@dotNomad dotNomad marked this pull request as ready for review March 21, 2024 00:05
@dotNomad dotNomad marked this pull request as draft March 21, 2024 00:11
@dotNomad
Copy link
Collaborator Author

Converting this to a draft since we will need to fix up our ESLint rules first.

Copy link
Collaborator

@sagerb sagerb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been prettiefied!

@tdstein
Copy link
Collaborator

tdstein commented Mar 21, 2024

@sagerb - the CI failures here look like disagreements between ESLint and Prettier. As @dotNomad mentioned, we'll need to update the ESLint rules to reflect the prettier behavior.

@dotNomad - is there a simple way to do this? Or is in inevitably a manual process?

@mmarchetti
Copy link
Contributor

@sagerb sagerb changed the base branch from dotnomad/web-ignore-cache to prettier-introduction-integration-branch March 21, 2024 18:27
@sagerb sagerb marked this pull request as ready for review March 21, 2024 18:30
@sagerb sagerb merged commit 9c36344 into prettier-introduction-integration-branch Mar 21, 2024
10 of 11 checks passed
@sagerb sagerb deleted the dotnomad/format-web branch March 21, 2024 18:30
@dotNomad
Copy link
Collaborator Author

dotNomad commented Mar 25, 2024

the CI failures here look like disagreements between ESLint and Prettier. As @dotNomad mentioned, we'll need to update the ESLint rules to reflect the prettier behavior.

@dotNomad - is there a simple way to do this? Or is in inevitably a manual process?

https://github.com/prettier/eslint-config-prettier ?

Bingo, however if you have ESLint rules set after the extends to overwrite those rules then you add back conflicts. Thats what was going on in the web dir since we had a lot of custom set ESLint rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants