Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isEntrypoint from files APIs #2436

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

dotNomad
Copy link
Collaborator

This PR removes the isEntrypoint attribute in the File struct used in the Files APIs

Intent

Resolves #2243

Type of Change

    • Bug Fix
    • New Feature
    • Breaking Change
    • Documentation
    • Refactor
    • Tooling

@dotNomad dotNomad merged commit 9abdb91 into main Nov 15, 2024
14 checks passed
@dotNomad dotNomad deleted the dotnomad/rm-is-entrypoint branch November 15, 2024 17:33
@marcosnav
Copy link
Collaborator

Validation - example output without isEntrypoint

{
  "id": ".",
  "fileType": "DIR",
  "base": "quarto-proj-r",
  "reason": null,
  "files": [
    {
      "id": ".Rprofile",
      "fileType": "REGULAR",
      "base": ".Rprofile",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": ".Rprofile",
      "relDir": ".",
      "size": 26,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/.Rprofile",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": ".gitattributes",
      "fileType": "REGULAR",
      "base": ".gitattributes",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": ".gitattributes",
      "relDir": ".",
      "size": 34,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/.gitattributes",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": ".gitignore",
      "fileType": "REGULAR",
      "base": ".gitignore",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": ".gitignore",
      "relDir": ".",
      "size": 28,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/.gitignore",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "README.md",
      "fileType": "REGULAR",
      "base": "README.md",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "README.md",
      "relDir": ".",
      "size": 380,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/README.md",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "_quarto.yml",
      "fileType": "REGULAR",
      "base": "_quarto.yml",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "_quarto.yml",
      "relDir": ".",
      "size": 50,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/_quarto.yml",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "manifest.json",
      "fileType": "REGULAR",
      "base": "manifest.json",
      "reason": {
        "source": "built-in",
        "pattern": "!manifest.json",
        "exclude": true,
        "fileName": "",
        "filePath": ""
      },
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "manifest.json",
      "relDir": ".",
      "size": 81200,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/manifest.json",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "meta.yaml",
      "fileType": "REGULAR",
      "base": "meta.yaml",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "meta.yaml",
      "relDir": ".",
      "size": 91,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/meta.yaml",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "quarto-proj-r.Rproj",
      "fileType": "REGULAR",
      "base": "quarto-proj-r.Rproj",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "quarto-proj-r.Rproj",
      "relDir": ".",
      "size": 204,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/quarto-proj-r.Rproj",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "quarto-proj-r.qmd",
      "fileType": "REGULAR",
      "base": "quarto-proj-r.qmd",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "quarto-proj-r.qmd",
      "relDir": ".",
      "size": 235,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/quarto-proj-r.qmd",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "renv",
      "fileType": "DIR",
      "base": "renv",
      "reason": null,
      "files": [
        {
          "id": "renv/.gitignore",
          "fileType": "REGULAR",
          "base": ".gitignore",
          "reason": null,
          "files": [],
          "isDir": false,
          "isFile": true,
          "modifiedDatetime": "2024-08-23T02:42:05+09:00",
          "rel": "renv/.gitignore",
          "relDir": "renv",
          "size": 56,
          "fileCount": 1,
          "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv/.gitignore",
          "allIncluded": false,
          "allExcluded": true
        },
        {
          "id": "renv/activate.R",
          "fileType": "REGULAR",
          "base": "activate.R",
          "reason": null,
          "files": [],
          "isDir": false,
          "isFile": true,
          "modifiedDatetime": "2024-08-23T02:42:05+09:00",
          "rel": "renv/activate.R",
          "relDir": "renv",
          "size": 27992,
          "fileCount": 1,
          "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv/activate.R",
          "allIncluded": false,
          "allExcluded": true
        },
        {
          "id": "renv/settings.dcf",
          "fileType": "REGULAR",
          "base": "settings.dcf",
          "reason": null,
          "files": [],
          "isDir": false,
          "isFile": true,
          "modifiedDatetime": "2024-08-23T02:42:05+09:00",
          "rel": "renv/settings.dcf",
          "relDir": "renv",
          "size": 238,
          "fileCount": 1,
          "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv/settings.dcf",
          "allIncluded": false,
          "allExcluded": true
        },
        {
          "id": "renv/settings.json",
          "fileType": "REGULAR",
          "base": "settings.json",
          "reason": null,
          "files": [],
          "isDir": false,
          "isFile": true,
          "modifiedDatetime": "2024-08-23T02:42:05+09:00",
          "rel": "renv/settings.json",
          "relDir": "renv",
          "size": 343,
          "fileCount": 1,
          "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv/settings.json",
          "allIncluded": false,
          "allExcluded": true
        }
      ],
      "isDir": true,
      "isFile": false,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "renv",
      "relDir": ".",
      "size": 28629,
      "fileCount": 4,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv",
      "allIncluded": false,
      "allExcluded": true
    },
    {
      "id": "renv.lock",
      "fileType": "REGULAR",
      "base": "renv.lock",
      "reason": null,
      "files": [],
      "isDir": false,
      "isFile": true,
      "modifiedDatetime": "2024-08-23T02:42:05+09:00",
      "rel": "renv.lock",
      "relDir": ".",
      "size": 8713,
      "fileCount": 1,
      "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r/renv.lock",
      "allIncluded": false,
      "allExcluded": true
    }
  ],
  "isDir": true,
  "isFile": false,
  "modifiedDatetime": "2024-08-23T02:42:05+09:00",
  "rel": ".",
  "relDir": ".",
  "size": 119590,
  "fileCount": 14,
  "abs": "/Users/mn/Posit/publisher/test/sample-content/quarto-proj-r",
  "allIncluded": false,
  "allExcluded": true
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove isEntrypoint in the files API
2 participants