Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isEntrypoint from files APIs #2436

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Remove isEntrypoint from files APIs #2436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion extensions/vscode/src/api/types/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ export type ContentRecordFile = {
reason: FileMatch | null; // pattern that matched a file, null if no match
files: ContentRecordFile[];
isDir: boolean;
isEntrypoint: boolean;
isFile: boolean;
modifiedDatetime: string;
rel: string;
Expand Down
1 change: 0 additions & 1 deletion internal/services/api/files/files.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ type File struct {
Reason *matcher.Pattern `json:"reason"` // object describing the reason the file was included/excluded, or null if no pattern matched it
Files []*File `json:"files"` // an array of objects of the same type for each file within the directory.
IsDir bool `json:"isDir"` // true if the file is a directory
IsEntrypoint bool `json:"isEntrypoint"` // true if the file is an entrypoint
IsRegular bool `json:"isFile"` // true if the file is a regular file
ModifiedDatetime string `json:"modifiedDatetime"` // the last modified datetime
Rel string `json:"rel"` // the relative path to the project root, which is used as the identifier
Expand Down
4 changes: 0 additions & 4 deletions internal/services/api/files/services_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ func (s *ServicesSuite) TestGetFileUsingSampleContent() {
s.Equal(Directory, file.FileType)
s.True(file.IsDir)
s.False(file.IsRegular)
s.False(file.IsEntrypoint)
s.NotNil(file.Files)
s.False(file.AllExcluded)
s.False(file.AllIncluded)
Expand Down Expand Up @@ -155,7 +154,6 @@ func (s *ServicesSuite) TestGetFileUsingSampleContentFromParentDir() {
s.Equal(Directory, file.FileType)
s.True(file.IsDir)
s.False(file.IsRegular)
s.False(file.IsEntrypoint)
s.NotNil(file.Files)
s.False(file.AllExcluded)
s.False(file.AllIncluded)
Expand Down Expand Up @@ -185,7 +183,6 @@ func (s *ServicesSuite) TestGetFileUsingSampleContentAllIncluded() {
s.Equal(Directory, file.FileType)
s.True(file.IsDir)
s.False(file.IsRegular)
s.False(file.IsEntrypoint)
s.NotNil(file.Files)
s.False(file.AllExcluded)
s.True(file.AllIncluded)
Expand Down Expand Up @@ -215,7 +212,6 @@ func (s *ServicesSuite) TestGetFileUsingSampleContentAllExcluded() {
s.Equal(Directory, file.FileType)
s.True(file.IsDir)
s.False(file.IsRegular)
s.False(file.IsEntrypoint)
s.NotNil(file.Files)
s.True(file.AllExcluded)
s.False(file.AllIncluded)
Expand Down