Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ESLint to Cypress #293

Closed
wants to merge 127 commits into from
Closed

Adds ESLint to Cypress #293

wants to merge 127 commits into from

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Oct 17, 2023

Intent

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change

Approach

Automated Tests

Directions for Reviewers

Checklist

@tdstein
wip
53f6783
@tdstein
Merge remote-tracking branch 'origin/main' into tdstein/release
b3f209c
@tdstein
Adds scripts to determine release stage.
9e5ead2
@tdstein
Adds CONTRIBUTING.md with release instructions
1737c09
@tdstein
Adds documentation
91927ea
@tdstein
Disables copyright checking
7b35846
@tdstein
Adds ./scripts/stub.bash to fake web/dist
3aa6804
@tdstein
Factors .github/workflows/pull-request.yaml
dfedc65
@tdstein
Factors end-to-end tests
398b0d6
@tdstein
Utilizes GitHub Action cache.
61c0dcd
@tdstein
Reverts changes to E2E
c6509bc
@tdstein
Fixes Justfile calls
80a0083
@tdstein
Fixes grammar in CONTRIBUTING.md
e5f5643
@tdstein
Sets fetch-depth to 0
ba81e2a
@tdstein
wip
ad0a246
@tdstein
Abstracts package-path
62bd684
@tdstein
Disables Docker when executing E2E tests in CI.
36026e6 
Sets DOCKER=false when executing "test:e2e:ci" to avoid executing
Docker-in-Docker within GitHub Actions.
@tdstein
Auto builds image in Docker mode.
1a6a523
@tdstein
Adds python3 to Dockerfile
3127f55
@tdstein
Adds xorg-x11-server-Xvfb.
a333636
@tdstein
Adds packages required by Cypress to Dockerfile
b517182
@tdstein
Sets NodeJS to version 16.
5b2eadb
@tdstein
Big commit. See full commit message.
4b8fa8d 
- Adds copious comments to Justfile.
- Fixes arch and os parsing in ./script/build.bash
- Moves Dockerfile to ./build/ci.
- Renames references to packages with executables.
@tdstein
Adds DEBUG env var to Justfile
8b42881
@tdstein
Fixes string parsing of $arch
8e2ff0c
@tdstein
Removes dependencies on executable
5e27cc3
@tdstein
Refactors Cypress invocation
40e1012
@tdstein
Fixes _uid_args
6bf0698
@tdstein
Enable DEBUG mode
9c7b881
@tdstein
Sets user on all operating systems
2640707
tdstein added 23 commits October 13, 2023 13:54
@tdstein
Fix default target.
d931221
@tdstein
Adjust cypress install
677acdd
@tdstein
Removes accidentally commited node_modules.
5311059
@tdstein
Merge pull request #268 from rstudio/tdstein/cypress
86b0f30 
Moves Cypress tests to ./tests/cy
@tdstein
Merges JupyterLab extension.
7dbd950
@tdstein
Sets correct commands
c73d1c6
@tdstein
Disables DOCKER
180c78a
@tdstein
Fix target
feea556
@tdstein
Adds 'just all' and 'just fix'.
7d8cbe3
@tdstein
Adds aliases
a2566ee
@tdstein
Fixes 'just all' default execution
42c65fc
@tdstein
Merge branch 'tdstein/release' into tdstein/jupyterlab-ci
e097389
@tdstein
Merge pull request #289 from rstudio/tdstein/jupyterlab-ci
16a6000 
JupyterLab CI
@tdstein
Merge remote-tracking branch 'origin/main' into tdstein/release
be5b78c
@tdstein
Updates workflow
5bf126a
@tdstein
Modifies type declarations to resolve mypy
af75747
@tdstein
Fixes Main workflow
c2a006a
@tdstein
Merge branch 'tdstein/release' into tdstein/resolve-linting-error
7359229
@tdstein
Merge pull request #292 from rstudio/tdstein/resolve-linting-error
81a92c1 
Resolves MyPy errors
@tdstein
Removes junit.xml
50e20e9
@tdstein
Run 'clean' without Docker
2834bc5
@tdstein
Adds install target and fixes _with_docker invocation
38407c6
@tdstein
Adds ESLint configuration for Cypress
4a9caab
@tdstein tdstein changed the base branch from main to tdstein/release October 17, 2023 14:51
@tdstein tdstein mentioned this pull request Oct 17, 2023
Merged
4 tasks
dotNomad
dotNomad approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@dotNomad dotNomad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gives us linting Cypress which is great, and uses the Cypress ESLint Plugin 🎉
Left a note about missing the same ESLint config from web if that matters for us.

test/cy/.eslintrc.cjs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great because it extends the Cypress ESLint plugin and enables the Cypress globals for linting, however if we care about linting all of our JS / TS files the same we are missing all of the rules and plugins from publishing-client/web/.eslintrc.cjs. Granted not all of those rules are applicable since this doesn't use Vue and are no longer using TypeScript here.

Base automatically changed from tdstein/release to main October 18, 2023 15:01
@tdstein tdstein closed this Oct 18, 2023
@tdstein tdstein deleted the tdstein/eslint-cypress branch October 18, 2023 15:27
@dotNomad dotNomad mentioned this pull request Oct 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotNomad dotNomad dotNomad approved these changes

@sagerb sagerb Awaiting requested review from sagerb sagerb will be requested when the pull request is marked ready for review sagerb is a code owner

@marcosnav marcosnav Awaiting requested review from marcosnav marcosnav will be requested when the pull request is marked ready for review marcosnav is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tdstein @dotNomad