-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI Tests: Deploy all Python Content Types #816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not fully review this but:
- looks like you have some duplicate commits in here perhaps something got a bit messed up in Git
- we are adding some large files including images in this PR, should we consider separating this out to avoid bloating the size of this repo?
The sample content was pulled in from the Jumpstart examples from Connect. I removed the images and README files, good catch. |
I think I had to pull in changes from |
I'm looking at the commits in the PR you have commits you have written, but also some from me and Taylor. Like the HTML5 history one has a different SHA than the commit on |
Thanks for removing these. I never like to include non-code like images in a repo if it can be helped. I've worked with too many multiple GBs repos in the past that felt so sluggish due to this. |
Should we have a separate repository for sample content? Is there an advantage to reusing the sample content across this project and Connect? Also, if necessary, we can place large non-text files in S3. |
It would be good to squash this PR when merging so the images won't be included (a regular merge will preserve the commit that added them and the commit that removed them). |
Since we have all of this content in Connect, I could do a Also for context, I'm using the Jumpstart examples because we publish those in the Connect product as examples for customers so we'll want to make sure those work with the publisher. |
Perhaps it would be best to close up this PR, and re-branch for the new work if we will be grabbing the sample content from Connect. |
Can this be closed now that #926 is open? |
Yup! Closing... |
Intent
Type of Change
Approach
This PR deploys all content. All Connect Jumpstart examples are added as well as various supported APIs. It also introduces a CONTENT variable where you can specify a single piece of content rather than deploying all.
After deploying, we check the Content Type using the API. I've added a
.env
file to each content folder to specify the expected content type to compare against.This PR also disables the nightly Cypress tests until we're ready to re-enable those (they're currently failing).
Automated Tests
These are them.
Directions for Reviewers
The deployments will only run during the Nightly tests, these are passing here:
https://github.com/posit-dev/publisher/actions/runs/7544245350/job/20537305258
This PR has 91 files but most of those are the added contents, feel free to ignore anything in the
test/sample-content/python
folder.Checklist