-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLI Deploy Tests #926
Merged
Merged
Add CLI Deploy Tests #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgartland-rstudio
requested review from
dotNomad,
mmarchetti,
sagerb and
tdstein
as code owners
January 31, 2024 16:34
mmarchetti
approved these changes
Jan 31, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR supplants #816. Much of it is similar but we now use the
connect-content
repo for all our testing content. When testing locally, we assume the location of${HOME}/work/connect-content
(because that's where my repo is and I'll probably do the majority of local testing). However you can also setCONTENT_REPO
to your own path.Type of Change
Approach
it scans the connect-content bundles directory for any folder that has a
test/.publisher-env
file and if found, it deploys the content and run the tests inbats/contract/deploy.bats
. The.publisher-env
files is where I store variables to assert against, currently it only contains the expected content type of the content.Automated Tests
these are them.
Directions for Reviewers
tests are passing
https://github.com/posit-dev/publisher/actions/runs/7728709804/job/21070355985, you can review all the content being deployed/redeployed in the
Run just bats test-contract
step.Checklist