-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix render.download not working in Express #1084
Conversation
Yup, the example's in the right place. 👍 |
The Playwright failures appear to be real!? api-examples/Progress/app-express.py is throwing an error Yes, my adding the |
The issue specifically depends on using a from shiny import reactive
from shiny.express import input, render, ui
ui.input_action_button("btn", "Press me!")
@render.text
# @reactive.event(input.btn)
def text():
return f"Number of clicks: {input.btn()}" |
Shouldn't it be |
Yes it should, but |
In case it matters to anyone, I found the source of the bug in py-shiny/shiny/session/_utils.py Line 57 in fc55acc
should be cs = _current_session.get()
return cs if cs is not None else _default_session |
@gadenbuie good find! I feel like falsiness in general causes more problems than it helps with. I think we should fix that in another PR. |
Closing because this was fixed by #1085. |
@gadenbuie Did I put the Express example in the right place?