Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix render.download in Shiny Express, take 2 #1085

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Conversation

wch
Copy link
Collaborator

@wch wch commented Jan 29, 2024

This PR supersedes #1084.

Note that the solution here is similar to the one in used #1049. In the future, it should be replaced with a check that doesn't need to explicitly know about MockSessions at that location.

Another odd thing about the existing code is that it accesses and modifies session._downloads directly. Perhaps a better fix is to add a method like Session.register_download().

Both of the proposed changes mentioned above are more invasive than this one, so it would be best to do them in a future PR, after things have settled down.

@wch wch marked this pull request as ready for review January 29, 2024 23:16
@wch wch merged commit 3612c21 into main Jan 30, 2024
26 checks passed
@wch wch deleted the render-download-express-2 branch January 30, 2024 04:03
schloerke added a commit that referenced this pull request Feb 13, 2024
* main: (33 commits)
  test: Test apps locally before deploying via pytest fixtures. (#1055)
  docs: Add ExtendedTask to API index (#1088)
  Fix `render.download` in Shiny Express, take 2 (#1085)
  Bump version to 0.7.0.9000
  Create two different api doc folders, one for Core and one for Express (#1053)
  chore: Pin black to version 23 (#1077)
  chore: Remove github link to shinylive (#1069)
  Bump version to 0.7.0
  Raise when `express.[input,output,session]` are used outside of Express app (#1067)
  Update dashboard template (#1056)
  chore: Remove many broken quartodoc links (#1061)
  Update {bslib} (#1062)
  Update docstrings for `expressify`, `hold`, and `render.express` (#1066)
  Add `fill` to `__all__` in `ui` and `express.ui` (#1064)
  Update shiny.js (#1059)
  docs(examples): Use refactored shinylive syntax (#1048)
  Update `shiny.js` (#1052)
  Add `express.ui.panel_title` (#1039)
  Don't run `effect`s created in a `MockSession` (#1049)
  Delete shiny/api-examples/Calc directory (#1044)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants