Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Editable data frame #1198

Merged
merged 119 commits into from
Mar 21, 2024
Merged

feat: Editable data frame #1198

merged 119 commits into from
Mar 21, 2024

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Mar 6, 2024 •
edited
Loading

Related: #1135
Related: #1119

Gordon Shotwell and others added 30 commits February 13, 2024 16:28
Add clearRows method for dataframe
e0d3666
Add multiple selection.
9d2224c
Tests
0d44d4c
Attach listeners to element
ba29703
Merge remote-tracking branch 'origin/main' into update_row_selection
ad3afc9
Raise errors on python side for row_selection_mode
3a959d6
@schloerke
Merge branch 'main' into update_row_selection
9823f92 
* main:
  bug(module): Do not use the module prefix in the `Renderer.output_id` (#1130)
  Replace `sys.stderr.write()` with `print(file=sys.stderr)` (#1131)
Add testing app
93a1bd0
Merge branch 'update_row_selection' of https://github.com/rstudio/py-…
05fa582 
…shiny into update_row_selection
@schloerke
Update _dataframe.py
560ba53
@schloerke
Update render.data_frame.input_selected_rows() return type and docs
62fd554
@schloerke
Move test
034961b
@schloerke @gshotwell
Add dataframe test for row selection
f1f71c0 
Co-Authored-By: Gordon Shotwell <[email protected]>
@schloerke
lints
dae65cb
@schloerke
Update Makefile
d0a4307
@schloerke
Add render.dataframe.{data, input_selected_rows, data_selected_rows}(…
f398147 
…)` methods
@schloerke
Update Makefile
e8058b4
@schloerke
cleanup
7ab3763
@schloerke
Merge branch 'main' into update_row_selection
04592db
@schloerke
Build js
5644259
@schloerke
Add palmerpenguins for testing
8f8b437
@schloerke
Merge branch 'main' into update_row_selection
c0c3c01
@schloerke
Merge branch 'main' into update_row_selection
2dfc272 
* main:
  bug: Remove timezone info from `shiny.datetime` input handler (#1146)
@schloerke
Allow for minify to be set from process args
91f6cf8
@schloerke
Remove title from matplotlib typings
eba2680
@schloerke
Add extra exception for missing handlers
6de0f9c
@schloerke
First pass at data_patched and on cell update
e09a48f
@schloerke
Round trip POC with editable data cells in table
01c54f0
@schloerke
lints
ea20817
@schloerke
Add eslint-plugin-react-hooks
6817dd0
wch
wch reviewed Mar 20, 2024
View reviewed changes
shiny/render/renderer/_dispatch.py Outdated Show resolved Hide resolved
shiny/render/_dataframe.py Show resolved Hide resolved
shiny/render/renderer/_dispatch.py Outdated Show resolved Hide resolved
shiny/session/_session.py Show resolved Hide resolved
shiny/session/_session.py Outdated Show resolved Hide resolved
shiny/session/_session.py Show resolved Hide resolved
shiny/session/_session.py Outdated Show resolved Hide resolved
shiny/session/_session.py Outdated Show resolved Hide resolved
shiny/session/_session.py Outdated Show resolved Hide resolved
shiny/session/_session.py Outdated Show resolved Hide resolved
schloerke added 18 commits March 20, 2024 14:03
@schloerke
Copy link
Collaborator Author

Failures are from main branch:
Ex: FAILED tests/playwright/shiny/session/flush/test_on_flush.py::test_output_image_kitchen[webkit] - ValueError: substring not found

Merging

@schloerke schloerke marked this pull request as ready for review March 21, 2024 20:01
@schloerke schloerke merged commit ebdb97b into main Mar 21, 2024
27 of 32 checks passed
@schloerke schloerke deleted the edit_data_frame branch March 21, 2024 20:02
schloerke added a commit to joesho112358/py-shiny that referenced this pull request Mar 23, 2024
@schloerke
Merge branch 'main' into sidebar-valuebox-tests
13d123b 
* main: (24 commits)
  chore: Disable broken test on CI; Fix broken docs entries (posit-dev#1241)
  Add back missing session methods (posit-dev#1239)
  Add kitchensink tests for valuebox (posit-dev#1229)
  For Express, emit message if need to upgrade rsconnect-python (posit-dev#1233)
  feat: Editable data frame (posit-dev#1198)
  Add tests for shiny_mode comment detection
  fix(input_dark_mode): Allow users to customize `style` attribute (posit-dev#1207)
  chore(get_current_session): Return default session if current is explicitly None (posit-dev#1086)
  chore: use dev htmtlools (posit-dev#1228)
  feat(layout_columns): Use `sm` as the default `col_widths` breakpoint (posit-dev#1222)
  feat: ensure min/max height args on `value_box()` and column layouts (posit-dev#1223)
  fix(static_assets): Need the directory containing the `app.py`, not the file itself (posit-dev#1219)
  Update bslib and shiny dependencies (posit-dev#1221)
  Update docstring and give hint for mypy
  Add support for Shiny Express in Quarto Dashboards, take 2 (posit-dev#1217)
  Force UTF-8 for Shiny Express on Windows (posit-dev#1203)
  Typing fixes
  feat(card): Report full screen state as a Shiny input (posit-dev#1215)
  Use TypeScript strict mode (posit-dev#1208)
  Update author email
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Programatically change data frame selection
2 participants
@schloerke @wch