Code

feat: Editable data frame#1198

Code

Merged

schloerke merged 119 commits intomainposit-dev/py-shiny:mainfrom edit_data_frameposit-dev/py-shiny:edit_data_frameCopy head branch name to clipboardMar 21, 2024

+2,578-383

Commits

Commits on Feb 13, 2024

• Add clearRows method for dataframe

  

  Gordon Shotwell

  committed
  e0d3666

Commits on Feb 14, 2024

• Add multiple selection.

  

  Gordon Shotwell

  committed
  9d2224c

• Tests

  

  Gordon Shotwell

  committed
  0d44d4c

• Attach listeners to element

  

  Gordon Shotwell

  committed
  ba29703

Commits on Feb 15, 2024

• Merge remote-tracking branch 'origin/main' into update_row_selection

  

  Gordon Shotwell

  committed
  ad3afc9

• Raise errors on python side for row_selection_mode

  

  Gordon Shotwell

  committed
  3a959d6

Commits on Feb 16, 2024

• Merge branch 'main' into update_row_selection

  Show description for 9823f92
  schloerke

  committed
  9823f92

• Add testing app

  

  Gordon Shotwell

  committed
  93a1bd0

• Merge branch 'update_row_selection' of https://github.com/rstudio/py-shiny into update_row_selection

  

  Gordon Shotwell

  committed
  05fa582

• Update _dataframe.py

  schloerke

  committed
  560ba53

• Update render.data_frame.input_selected_rows() return type and docs

  schloerke

  committed
  62fd554

Commits on Feb 20, 2024

• Move test

  schloerke

  committed
  034961b

• Add dataframe test for row selection

  Show description for f1f71c0
  

  schloerke

  and

  gshotwell

  committed
  f1f71c0

• lints

  schloerke

  committed
  dae65cb

• Update Makefile

  schloerke

  committed
  d0a4307

• Add render.dataframe.{data, input_selected_rows, data_selected_rows}()` methods

  schloerke

  committed
  f398147

• Update Makefile

  schloerke

  committed
  e8058b4

• cleanup

  schloerke

  committed
  7ab3763

• Merge branch 'main' into update_row_selection

  schloerke

  authored
  04592db

• Build js

  schloerke

  committed
  5644259

• Add palmerpenguins for testing

  schloerke

  committed
  8f8b437

• Merge branch 'main' into update_row_selection

  schloerke

  authored
  c0c3c01

Commits on Feb 21, 2024

• Merge branch 'main' into update_row_selection

  Show description for 2dfc272
  schloerke

  committed
  2dfc272

Commits on Feb 22, 2024

• Allow for minify to be set from process args

  schloerke

  committed
  91f6cf8

• Remove title from matplotlib typings

  schloerke

  committed
  eba2680

• Add extra exception for missing handlers

  schloerke

  committed
  6de0f9c

• First pass at data_patched and on cell update

  schloerke

  committed
  e09a48f

• Round trip POC with editable data cells in table

  schloerke

  committed
  01c54f0

• lints

  schloerke

  committed
  ea20817

Commits on Feb 26, 2024

• Add eslint-plugin-react-hooks

  schloerke

  committed
  6817dd0

• Reorganize edit info to be parallel with data info

  schloerke

  committed
  f2c380b

• Use array when updating data. Add tab support. Prevent enter/tab default methods

  schloerke

  committed
  b39abf9

• api!: Consolidate Outputs internal maps into a single map. Add outputRPC request handler

  schloerke

  committed
  e24eaf9

• Update _mock_session.py

  schloerke

  committed
  d1c7055

• compile

  schloerke

  committed
  3b4e864

• Use reactive calcs to resolve derived properties of value. E.g. data or row_selection_mode

  schloerke

  committed
  8bdfbce

• Update apps

  schloerke

  committed
  41fb078

Commits on Feb 27, 2024

• Resolve feedback; wording

  schloerke

  committed
  8d3e73a

• Merge branch 'main' into update_row_selection

  Show description for b7a0a82
  schloerke

  committed
  b7a0a82

• lints

  schloerke

  committed
  01cf0dd

• Remove some make help entries. Add js entries to build assets

  schloerke

  committed
  ddf9725

• Use FORCE instead of wild card .PHONY

  schloerke

  committed
  9b196e0

• lints

  schloerke

  committed
  9aacebd

• Fix test

  schloerke

  committed
  77b37cb

• Only go into editing mode if editable is true

  schloerke

  committed
  6a4c13f

• Add future TODO

  schloerke

  committed
  2e90631

• Update app.py

  schloerke

  committed
  2ddaa58

• Remove duplicate patches

  schloerke

  committed
  fe985a7

Commits on Feb 29, 2024

• api!: Update session._send_error_message() to be async and handle the tag

  schloerke

  committed
  14e07dd

• Use mode instead of row_selection_mode

  schloerke

  committed
  0313c6a

• JS updates

  schloerke

  committed
  7ac9c7c

• compile

  schloerke

  committed
  70af535

Commits on Mar 1, 2024

• Give the written value until a response from the server comes back

  schloerke

  committed
  ea6173c

• Save a success border on edit success. Fade out after 3s over 3s; Use danger border / background on failure to save

  schloerke

  committed
  f546e38

• Move Jsonifiable to shiny.types

  schloerke

  committed
  f453654

• Use Jsonifiable in message handlers

  schloerke

  committed
  83a7dae

• Use column indexes, not column ids

  schloerke

  committed
  bceaf85

Commits on Mar 3, 2024

• Move outputRPC to be defined within Outputs class; Create a session proxy and isolate to prevent handlers from requiring it

  schloerke

  committed
  8b87e09

• Code feedback from joe/winston;

  schloerke

  committed
  096c31b

• compile js

  schloerke

  committed
  f3c6eef

Commits on Mar 6, 2024

• Merge branch 'main' into update_row_selection

  Show description for 0de93ad
  schloerke

  committed
  0de93ad

• Post merge reverting the revert back to expected behavior

  schloerke

  committed
  9f7642d

• Remove fixed height of 500px when there are no rows to render

  schloerke

  committed
  3017782

• Update scroll height again

  schloerke

  committed
  5c82fe2

• Followup from Joe's comments

  Show description for b743b94
  schloerke

  committed
  b743b94

• lints

  schloerke

  committed
  cdce6a9

Commits on Mar 15, 2024

• Merge branch 'main' into edit_data_frame

  Show description for 4c574ec
  schloerke

  committed
  4c574ec

• Use outline, not border

  schloerke

  committed
  18daa3a

• Add output handler mark method for renderers

  schloerke

  committed
  dd129a5

• Compile

  schloerke

  committed
  a35fea0

• lints

  schloerke

  committed
  bb96021

• Copy pandas data when applying the patches

  schloerke

  committed
  d355e85

• Merge branch 'main' into edit_data_frame

  schloerke

  authored
  74e8e09

• Only set the session message handlers if the session is of type Session

  schloerke

  committed
  2255579

• Don't edit everthing. Only when editable

  schloerke

  committed
  e3dcd25

• Address strict mode lints

  schloerke

  committed
  2d20aca

• lints

  schloerke

  committed
  62f2a2b

• Update CHANGELOG.md

  schloerke

  committed
  b586efe

• Remove large comments

  schloerke

  committed
  bec0782

Commits on Mar 18, 2024

• First pass at removing enum from code. Using const object for literal access

  schloerke

  committed
  5fc2ff6

• Code feeback

  schloerke

  committed
  a744305

• Get cell classes to match with style names

  schloerke

  committed
  17d6ccd

• Move demo error handling to app

  schloerke

  committed
  f5e73d6

• Add comment on why we're setting the value with the initialValue

  schloerke

  committed
  ba8a6c5

Commits on Mar 19, 2024

• Code feedback

  schloerke

  committed
  75ee31e

• Add notes on keyboard navigation for the future

  schloerke

  committed
  9893ba1

• use text area instead of text input

  schloerke

  committed
  961cc20

• Autoresize height

  schloerke

  committed
  f94d9ea

• Add comment about cellContentEditable

  schloerke

  committed
  ec1d039

Commits on Mar 20, 2024

• Consistent css selector

  schloerke

  committed
  c395cab

• Recommend vscode packages

  schloerke

  committed
  96c4104

• Only make scss files have large width

  schloerke

  committed
  fb2947a

• receiveMessage -> shinyDataFrameMessage

  schloerke

  committed
  ee353dd

• spelling

  schloerke

  committed
  5fcb002

• Add caution note

  schloerke

  committed
  fab6fd0

• Merge branch 'main' into edit_data_frame

  schloerke

  authored
  f949c3f

• Merge branch 'edit_data_frame' of https://github.com/posit-dev/py-shiny into edit_data_frame

  schloerke

  committed
  edb7abb

• Update CHANGELOG.md

  schloerke

  committed
  4470df0

• Add comments about odd init order

  schloerke

  committed
  0694ed8

• Use _get_session() to properly scope

  schloerke

  committed
  faf680b

• Update _dataframe.py

  schloerke

  committed
  984e677

• Fix bug in selection mode

  schloerke

  committed
  d632e5c

• Use clearer variable name handler_fn_name

  schloerke

  committed
  afcf022

• Add file=sys.stderr to error print statements

  schloerke

  committed
  ae03360

• Reraise original error

  schloerke

  committed
  9a9ffe0

Commits on Mar 21, 2024

• Do not recommend isort. Too it isn't listening to setup.cfg

  schloerke

  committed
  f5607dc

• Add promise make request method. Update submission type. Add more keyboard notes

  schloerke

  committed
  9ff8134

• cell{s}_update -> patch{es}; Use map to speed up deduping of patches

  schloerke

  committed
  05af8f5

• Make output binding request handler more robust

  schloerke

  committed
  d60e2a8

• Update test_renderer.py

  schloerke

  committed
  a104dac

• Compile and update edit app

  schloerke

  committed
  3e2f256

• lints

  schloerke

  committed
  8e2412b

• Update test_renderer.py

  schloerke

  committed
  8d51f8e

• Adjust test to not set a current session context

  schloerke

  committed
  8f8930b

• Fix tests

  schloerke

  committed
  c6e8493

• Add notes

  schloerke

  committed
  e9be77a

• lint

  schloerke

  committed
  9f67849

• Try using a TypeGuard so that py3.12 tests pass

  schloerke

  committed
  3247b8a

• Update _dispatch.py

  schloerke

  committed
  8e8282e