Wait 10s instead of 20s before asking user #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially had a 10s wait before the "would you like to continue" appears, but in #65 (comment) we bumped this to 20s.
I had forgotten that these 10s are balancing both slow-opening apps as well as apps that fail immediately. Because we're using
terminal.sendText(), we don't have any insight into what has happened in the Terminal. When an app fails immediately (sayshinyisn't installed), we still have to wait for the 10s timeout before we show the "something's not right dialog".To mitigate this, if the user clicks "keep waiting", we'll bump up the wait time to 30s.