Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait 10s instead of 20s before asking user #74

Merged
merged 4 commits into from
Aug 27, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
docs: document timeout param
gadenbuie committed Aug 27, 2024
commit 7ea6565c71c21137f6bfc8749d8cd1a2eab00e19
4 changes: 4 additions & 0 deletions src/net-utils.ts
Original file line number Diff line number Diff line change
@@ -57,6 +57,10 @@ async function getTerminalClosedPromise(
* @param port The port to open the browser for.
* @param additionalPorts Additional ports to wait for before opening the
* browser.
* @param timeout Milliseconds to wait for the port to open before letting the
* user know something is wrong and asking if they'd like to check on the Shiny
* process or keep waiting. We start with a low 10s wait because some apps might
* fail quickly, but we increase to 30s if the user chooses to keep waiting.
*/
export async function openBrowserWhenReady(
port: number,