Treat unsupported URLs as specified in Driver#connect to avoid overwriting the "real" exception #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipross
force-pushed
the
topic/driver
branch
from
08d6a6d to
ba372a2
Compare
|
I rebased the branch onto an updated main that has working CI again, but there are still things that fail with the unit tests. I'm not sure what the best way around these failures are. |
|
@phillipross You mean it's failing with this PR, or it already fails on master? |
|
It fails with this PR |
sebasbaumh
added a commit
to sebasbaumh/postgis-java-ng
that referenced
this pull request
Apr 27, 2022
rework/fix DriverWrapper and add test by postgis/postgis-java#115 , add/adjust documentation
…writing the "real" exception
…ection - FIX: acceptsURL() method rework to avoid potentially invoking super method with null param Signed-off-by: Phillip Ross <[email protected]>
phillipross
force-pushed
the
topic/driver
branch
from
ba372a2 to
d8bed3b
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.