Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oscillator-overlap: Make consistent with oscillator #597

Merged
merged 10 commits into from
Nov 27, 2024
Merged

oscillator-overlap: Make consistent with oscillator #597

merged 10 commits into from
Nov 27, 2024

Conversation

BenjaminRodenberg
Copy link
Member

@BenjaminRodenberg BenjaminRodenberg commented Nov 21, 2024 •
edited
Loading

Updates oscillator-overlap to use time stepping schemes and typing like in oscillator

Checklist:

  • I added a summary of any user-facing changes (compared to the last release) in the changelog-entries/<PRnumber>.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@BenjaminRodenberg BenjaminRodenberg self-assigned this Nov 21, 2024
@BenjaminRodenberg BenjaminRodenberg requested review from uekerman and removed request for fsimonis November 21, 2024 18:07
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Nov 22, 2024
Merged
3 tasks
uekerman
uekerman approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I did not look into the details and did not run the case.

changelog-entries/597.md Outdated Show resolved Hide resolved
@BenjaminRodenberg @uekerman
Update changelog-entries/597.md
5c13d04 
Co-authored-by: Benjamin Uekermann <[email protected]>
@BenjaminRodenberg
Add timeSteppers.py
7498874
@BenjaminRodenberg
Merge branch 'make-oscillator-overlap-consistent-to-oscillator' of gi…
5e7986a 
…thub.com:BenjaminRodenberg/tutorials into make-oscillator-overlap-consistent-to-oscillator
@NiklasVin NiklasVin self-requested a review November 27, 2024 10:03
NiklasVin
NiklasVin approved these changes Nov 27, 2024
View reviewed changes
Copy link
Collaborator

@NiklasVin NiklasVin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything works 👍

@BenjaminRodenberg BenjaminRodenberg merged commit d27d64f into precice:develop Nov 27, 2024
1 check passed
@BenjaminRodenberg BenjaminRodenberg deleted the make-oscillator-overlap-consistent-to-oscillator branch November 27, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiklasVin NiklasVin NiklasVin approved these changes

@uekerman uekerman uekerman approved these changes

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels
enhancement maintainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminRodenberg @uekerman @NiklasVin