Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on autocomplete attribute #867

Merged
merged 5 commits into from
Oct 1, 2024
Merged

Add note on autocomplete attribute #867

merged 5 commits into from
Oct 1, 2024

Conversation

TylerJDev
Copy link
Contributor

Add notes on autocomplete attribute usage in TextInput.

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀, minor suggestions

content/components/text-input.mdx Outdated Show resolved Hide resolved
content/components/text-input.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@aduggin aduggin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of small suggestion to provide more clarity

content/components/text-input.mdx Outdated Show resolved Hide resolved
content/components/text-input.mdx Outdated Show resolved Hide resolved
@TylerJDev TylerJDev merged commit 731ae43 into main Oct 1, 2024
6 checks passed
@TylerJDev TylerJDev deleted the autocomplete-notes branch October 1, 2024 00:21
lukasoppermann pushed a commit that referenced this pull request Oct 2, 2024
* Add note on `autocomplete` attribute

* Update content/components/text-input.mdx

Co-authored-by: Marie Lucca <[email protected]>

* Update content/components/text-input.mdx

Co-authored-by: Marie Lucca <[email protected]>

* Update content/components/text-input.mdx

Co-authored-by: Alistair Duggin <[email protected]>

* Update content/components/text-input.mdx

Co-authored-by: Alistair Duggin <[email protected]>

---------

Co-authored-by: Marie Lucca <[email protected]>
Co-authored-by: Alistair Duggin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants