Delete deprecated `MarkdownEditor`, `MarkdownInput`, `InlineAutocomplete`, and related code #4953

iansan5653 · 2024-09-12T16:19:07Z

Supercedes Remove MarkdownEditor and related code #4160
Closes Remove MarkdownEditor from @primer/react #3604
Closes https://github.com/github/primer/issues/2270

Changelog

Removed

Deprecated experimental components and hooks:

MarkdownEditor
MarkdownViewer
InlineAutocomplete
useCombobox
useDynamicTextareaHeight
useIgnoreKeyboardActionsWhileComposing
useSafeAsyncCallback
useSyntheticChange
useUnifiedFileSelect

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

changeset-bot · 2024-09-12T16:19:11Z

🦋 Changeset detected

Latest commit: 5a9e172

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2024-09-12T16:22:31Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	97.46 KB (0%)
packages/react/dist/browser.umd.js	97.72 KB (0%)

…itor

broccolinisoup · 2024-09-13T09:06:37Z

packages/react/src/TooltipV2/Tooltip.tsx

-                  // https://github.com/jsdom/jsdom/issues/3426
+                // Note: jsdom (jest) does not support `:focus-visible` yet
+                // https://github.com/jsdom/jsdom/issues/3426
+                if (!event.target.matches(':focus-visible') && !isJSDOM()) {


If reading the line of !event.target.matches(':focus-visible') doesn't throw an error (looks like it doesn't since the tests are all green), we are good!

joshblack

LGTM! Just waiting for a PR upstream to help with the type errors coming up since the location has changed 👀

iansan5653 · 2024-09-13T15:47:13Z

Just waiting for a PR upstream to help with the type errors coming up since the location has changed 👀

https://github.com/github/github/pull/342097

…rkdowneditor

primer-integration · 2024-09-17T16:08:46Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/342570

joshblack · 2024-09-17T16:48:05Z

Going to merge this in since I believe the failures upstream are related to changes we are already making in: https://github.com/github/github/pull/342428 for RC.5 👍

Thanks again for doing this @iansan5653! It was such a big help

…ete`, and related code (#4953) * Delete `MarkdownEditor`, `MarkdownInput`, and `InlineAutocomplete` * Add changeset * Delete snapshots * Update jest config and delete character-coordinates utils * Delete the `fzy` dependency * chore: add label to CommentBos story * test(vrt): update snapshots * fix: restore useSlots export from drafts * test: update tooltip test for bump in jsdom * Re-add slots and overflow exports * Try resetting the lockfile? * Switch logic to fix test output * Revert tooltip changes, no idea how those snuck in * Fix experimental hooks export --------- Co-authored-by: Josh Black <[email protected]>

iansan5653 added 2 commits September 12, 2024 16:16

Delete MarkdownEditor, MarkdownInput, and InlineAutocomplete

186ee14

Add changeset

3b0730f

iansan5653 requested a review from a team as a code owner September 12, 2024 16:19

iansan5653 requested a review from TylerJDev September 12, 2024 16:19

Delete snapshots

ab7e63b

iansan5653 temporarily deployed to github-pages September 12, 2024 16:21 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 16:21 Inactive

Update jest config and delete character-coordinates utils

ba20a89

iansan5653 requested a review from a team as a code owner September 12, 2024 16:21

iansan5653 requested a review from langermank September 12, 2024 16:21

Delete the fzy dependency

ac0a573

iansan5653 changed the title ~~Delete markdowneditor~~ Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code Sep 12, 2024

iansan5653 temporarily deployed to github-pages September 12, 2024 16:25 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 16:25 Inactive

joshblack self-requested a review September 12, 2024 16:29

joshblack mentioned this pull request Sep 12, 2024

Bring back "refactor: remove MarkdownEditor and MarkdownViewer (#4782)"" #4868

Closed

joshblack added the update snapshots label Sep 12, 2024

chore: add label to CommentBos story

86b5b9e

joshblack temporarily deployed to github-pages September 12, 2024 17:20 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 17:21 Inactive

test(vrt): update snapshots

69fec0d

github-actions bot removed the update snapshots label Sep 12, 2024

primer bot temporarily deployed to github-pages September 12, 2024 17:25 Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 17:25 Inactive

joshblack added 2 commits September 12, 2024 13:05

fix: restore useSlots export from drafts

e2c5ff4

Merge branch 'main' of github.com:primer/react into delete-markdowned…

0c1a696

…itor

joshblack temporarily deployed to github-pages September 12, 2024 20:33 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 20:33 Inactive

test: update tooltip test for bump in jsdom

7dff4b7

joshblack temporarily deployed to github-pages September 12, 2024 21:03 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 12, 2024 21:03 Inactive

broccolinisoup reviewed Sep 13, 2024

View reviewed changes

joshblack approved these changes Sep 13, 2024

View reviewed changes

iansan5653 added 4 commits September 16, 2024 19:44

Merge branch 'main' of https://github.com/primer/react into delete-ma…

664147e

…rkdowneditor

Merge branch 'main' of https://github.com/primer/react into delete-ma…

d957e2e

…rkdowneditor

Re-add slots and overflow exports

53fd10f

Try resetting the lockfile?

dcb594b

iansan5653 temporarily deployed to github-pages September 17, 2024 15:05 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 17, 2024 15:05 Inactive

iansan5653 added 2 commits September 17, 2024 15:11

Switch logic to fix test output

aa8a903

Revert tooltip changes, no idea how those snuck in

e70fd9e

iansan5653 temporarily deployed to github-pages September 17, 2024 15:13 — with GitHub Actions Inactive

github-actions bot temporarily deployed to storybook-preview-4953 September 17, 2024 15:14 Inactive

Fix experimental hooks export

5a9e172

iansan5653 deployed to github-pages September 17, 2024 15:19 — with GitHub Actions View deployment

github-actions bot deployed to storybook-preview-4953 September 17, 2024 15:19 View deployment

joshblack added this pull request to the merge queue Sep 17, 2024

Merged via the queue into main with commit 04e8c9c Sep 17, 2024
32 checks passed

joshblack deleted the delete-markdowneditor branch September 17, 2024 16:58

primer bot mentioned this pull request Sep 17, 2024

Release tracking (rc.6) #4980

Merged

broccolinisoup mentioned this pull request Sep 19, 2024

SelectPanel: Empty State - Explore SelectPanel.Message API and managing visibility of the component under the hood #4988

Closed

13 tasks

primer bot mentioned this pull request Oct 18, 2024

Release tracking (37.0.0) #5143

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete deprecated `MarkdownEditor`, `MarkdownInput`, `InlineAutocomplete`, and related code #4953

Delete deprecated `MarkdownEditor`, `MarkdownInput`, `InlineAutocomplete`, and related code #4953

iansan5653 commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

broccolinisoup Sep 13, 2024

joshblack left a comment

iansan5653 commented Sep 13, 2024

primer-integration bot commented Sep 17, 2024

joshblack commented Sep 17, 2024

Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code #4953

Delete deprecated MarkdownEditor, MarkdownInput, InlineAutocomplete, and related code #4953

Conversation

iansan5653 commented Sep 12, 2024 • edited Loading

Changelog

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

changeset-bot bot commented Sep 12, 2024 • edited Loading

🦋 Changeset detected

github-actions bot commented Sep 12, 2024 • edited Loading

size-limit report 📦

broccolinisoup Sep 13, 2024

Choose a reason for hiding this comment

joshblack left a comment

Choose a reason for hiding this comment

iansan5653 commented Sep 13, 2024

primer-integration bot commented Sep 17, 2024

joshblack commented Sep 17, 2024

Delete deprecated `MarkdownEditor`, `MarkdownInput`, `InlineAutocomplete`, and related code #4953

Delete deprecated `MarkdownEditor`, `MarkdownInput`, `InlineAutocomplete`, and related code #4953

iansan5653 commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading