fix: add new missing properties mocks (id, is_master)
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
lihbr
changed the title
id in asset mocksid in asset mocks
lihbr
changed the title
id in asset mocksid, is_master)
angeloashmore
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Asset mocks (image & link to media) are missing the now mandatory
idproperty.Somehow, rich text image nodes implemented it already, so I guess it was something we forgot to update because of casting: ca0b3da#diff-7c8caca1f8c362b6daf78fe210da74d78b8986913869c79c8078ef3697cabc6d, hence marking this PR as a fix (will squash'n'merge).
Similarly, repository mocks were missing the now mandatory
is_masterboolean.Checklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩