-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support link text #205
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left a few suggestions, none of which are blocking.
I'm going to mark the PR as "Request changes" because we should publish @prismicio/client
first and update the version here before merging. Let me know if you'd like to handle that a different way though.
On the PR status, we could go with |
@xrutayisire Could we discuss and conclude #205 (comment) before I approve this and the other SDK PRs? You're right about handling the version numbers after the approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
f3b01bf
to
3fd7cc4
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #205 +/- ##
==========================================
+ Coverage 99.68% 99.84% +0.15%
==========================================
Files 20 20
Lines 2569 2585 +16
Branches 97 99 +2
==========================================
+ Hits 2561 2581 +20
+ Misses 8 4 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
("text" in field | ||
? Object.keys(field).length > 2 | ||
: Object.keys(field).length > 1) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 #nice: The dev message code is still a little weird, but this is a nice and simple update to make your new work compatible. 😄
Resolves: DT-2272
Types of changes
Description
Checklist: