Add ODH CFO test specific support functions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sutaakar
force-pushed
the
odh-cfo-test
branch
from
449493a
to
9073432
Compare
astefanutti
approved these changes
Nov 9, 2023
support/core.go
Outdated
| @@ -98,7 +101,10 @@ func storeContainerLog(t Test, namespace *corev1.Namespace, podName, containerNa | |||
|
|
|||
| options := corev1.PodLogOptions{Container: containerName} | |||
| stream, err := t.Client().Core().CoreV1().Pods(namespace.Name).GetLogs(podName, &options).Stream(t.Ctx()) | |||
| t.Expect(err).NotTo(gomega.HaveOccurred()) | |||
| if err != nil { | |||
| t.T().Logf("Pod Container %s/%s/%s not found, logs cannot be stored", namespace.Name, podName, containerName) | |||
There was a problem hiding this comment.
This is more likely to fail when the Pod is still in pending phase, rather than because the container cannot be found. A more generic message may be better suited not to be misleading.
There was a problem hiding this comment.
Adjusted wording.
I suppose it doesn't have sense to print the error, considering that this is not a test failure.
sutaakar
force-pushed
the
odh-cfo-test
branch
from
9073432
to
dcbc3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
red-hat-data-services/distributed-workloads#23
What changes have been made
Add test support functions needed by ODH CFO tests.
Verification steps
N/A
Checks