add_entry-symmetry

project-tsurugi · Oct 19, 2023 · 8b561c8 · 8b561c8
1 parent f5564e7
commit 8b561c8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/include/limestone/api/log_channel.h b/include/limestone/api/log_channel.h
@@ -84,7 +84,7 @@ class log_channel {
      * @param large_objects (optional) the list of large objects associated with the entry to be added
      * @attention this function is not thread-safe.
      */
-    void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version, const std::vector<large_object_input>& large_objects) noexcept;
+    void add_entry(storage_id_type storage_id, std::string_view key, std::string_view value, write_version_type write_version, const std::vector<large_object_input>& large_objects);
 
     /**
      * @brief add an entry indicating the deletion of entries

diff --git a/src/limestone/log_channel.cpp b/src/limestone/log_channel.cpp
@@ -85,9 +85,9 @@ void log_channel::add_entry(storage_id_type storage_id, std::string_view key, st
     write_version_ = write_version;
 }
 
-void log_channel::add_entry([[maybe_unused]] storage_id_type storage_id, [[maybe_unused]] std::string_view key, [[maybe_unused]] std::string_view value, [[maybe_unused]] write_version_type write_version, [[maybe_unused]] const std::vector<large_object_input>& large_objects) noexcept {
+void log_channel::add_entry([[maybe_unused]] storage_id_type storage_id, [[maybe_unused]] std::string_view key, [[maybe_unused]] std::string_view value, [[maybe_unused]] write_version_type write_version, [[maybe_unused]] const std::vector<large_object_input>& large_objects) {
     LOG_LP(ERROR) << "not implemented";
-    std::abort();  // FIXME
+    throw std::runtime_error("not implemented");  // FIXME
 };
 
 void log_channel::remove_entry(storage_id_type storage_id, std::string_view key, write_version_type write_version) {