Add Dockerfile and documentation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add Dockerfile and update README for Docker setup
Nuhvi
reviewed
Nov 4, 2024
README.md
Outdated
| @@ -158,3 +158,35 @@ Open social networks often attempt to solve discovery natively within their netw | |||
| - Their infrastructure would need to become a gossip overlay network, which may not be desirable. | |||
| - Achieving consistency and load balancing would require further optimization, effectively reinventing a DHT. | |||
| - If an overlay network is developed that surpasses the performance of a 10-million-node DHT with a 15-year track record, Pkarr should still be capable of utilizing your network as a backend, either as an alternative or alongside existing solutions. | |||
|
|
|||
| 3. **How can I run the Pkarr server using Docker?** | |||
There was a problem hiding this comment.
Can you replace this with a link to the server's readme, and move all this to the. server readme?
The root Readme is meant to be mostly theory, and only links to implementation/examples/deployment details.
remove docker instructions from root README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll be maintaining these in case fixes are needed.