enable passed one-time scheduled actions to be rescheduled #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyobe
force-pushed
the
claire/fix-rescheduling-after-run
branch
from
a96cb2f to
ec17b81
Compare
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
komalali
approved these changes
Dec 7, 2024
nyobe
force-pushed
the
claire/fix-rescheduling-after-run
branch
3 times, most recently
from
4022a4a to
6727bf2
Compare
nyobe
force-pushed
the
claire/fix-rescheduling-after-run
branch
from
6727bf2 to
7c43fd7
Compare
IaroslavTitov
approved these changes
Dec 9, 2024
replaceOnChanges causes the generated sdks to apply an extra replaceOnChanges resource option that it passes through to the provider plugin. However, the yaml language doesn't have a generated sdk, so it doesn't work properly there. Instead, we now check for replacement in the provider plugin's Diff method instead, so it always works, and document this with `willReplaceOnChanges` (which is only used for documentation).
nyobe
force-pushed
the
claire/fix-rescheduling-after-run
branch
from
c2c0bdb to
b0ca860
Compare
komalali
reviewed
Dec 9, 2024
komalali
reviewed
Dec 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
|
This PR has been shipped in release v0.27.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-time schedules are soft-deleted after running, which means updating their schedule doesn't work because the action is never actually picked up again by the scheduler. (Prior to https://github.com/pulumi/pulumi-service/pull/24133 the update would appear to succeed, but the scheduled action would just silently never run. Now at least you get an error indicating the schedule was deleted.)
This PR enables rescheduling to work correctly by forcing the schedule to be replaced when its timestamp is updated.
Partially addresses #449