Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add order parameter to backend.calculate_norm #1043

Merged
merged 17 commits into from
Oct 16, 2023
Merged

Add order parameter to backend.calculate_norm #1043

merged 17 commits into from
Oct 16, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 12, 2023 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 12, 2023
@renatomello renatomello added this to the Qibo 0.2.2 milestone Oct 12, 2023
@renatomello renatomello self-assigned this Oct 12, 2023
@renatomello renatomello mentioned this pull request Oct 12, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/qibo/backends/abstract.py 100.00% <ø> (ø)
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)
src/qibo/backends/tensorflow.py 100.00% <100.00%> (ø)
src/qibo/quantum_info/metrics.py 100.00% <100.00%> (ø)
...qibo/quantum_info/superoperator_transformations.py 100.00% <100.00%> (ø)
src/qibo/quantum_info/utils.py 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

MatteoRobbiati
MatteoRobbiati approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks good to me. Just two little suggestions follow.

src/qibo/backends/abstract.py Outdated Show resolved Hide resolved
src/qibo/backends/abstract.py Outdated Show resolved Hide resolved
@renatomello renatomello merged commit 29fbea1 into master Oct 16, 2023
26 checks passed
@renatomello renatomello deleted the backend_improvement branch October 16, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@stavros11 stavros11 stavros11 approved these changes

@alecandido alecandido Awaiting requested review from alecandido

@AlejandroSopena AlejandroSopena Awaiting requested review from AlejandroSopena

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@renatomello @stavros11 @MatteoRobbiati