Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of frame_potential metric #1056

Merged
merged 17 commits into from
Dec 9, 2023
Merged

Implementation of frame_potential metric #1056

merged 17 commits into from
Dec 9, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 24, 2023 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 24, 2023
@renatomello renatomello self-assigned this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eea1e76) 100.00% compared to head (85ae492) 100.00%.

❗ Current head 85ae492 differs from pull request most recent head b724a4f. Consider uploading reports for the commit b724a4f to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #1056   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         9058      9078   +20     
=========================================
+ Hits          9058      9078   +20
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello mentioned this pull request Oct 24, 2023
Merged
4 tasks
@scarrazza scarrazza added this to the Qibo 0.2.3 milestone Nov 7, 2023
@MatteoRobbiati MatteoRobbiati modified the milestones: Qibo 0.2.3, Qibo 0.2.4 Nov 29, 2023
@renatomello renatomello marked this pull request as ready for review December 5, 2023 05:59
BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything's looking good to me

src/qibo/quantum_info/metrics.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/metrics.py Outdated Show resolved Hide resolved
renatomello and others added 2 commits December 7, 2023 11:23
@renatomello @BrunoLiegiBastonLiegi
Update src/qibo/quantum_info/metrics.py
aaccdef 
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
@renatomello @BrunoLiegiBastonLiegi
Update src/qibo/quantum_info/metrics.py
85ae492 
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
AlejandroSopena
AlejandroSopena approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@AlejandroSopena AlejandroSopena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @renatomello. Everything looks good.

MatteoRobbiati
MatteoRobbiati approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. A small suggestion follows, to fix the LaTeX rendering in the docs.

src/qibo/quantum_info/metrics.py Outdated Show resolved Hide resolved
@renatomello renatomello merged commit ad0cb94 into master Dec 9, 2023
18 of 19 checks passed
@renatomello renatomello deleted the frame_potential branch December 9, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatteoRobbiati MatteoRobbiati MatteoRobbiati approved these changes

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.2.4
Development

Successfully merging this pull request may close these issues.
5 participants
@renatomello @AlejandroSopena @BrunoLiegiBastonLiegi @MatteoRobbiati @scarrazza