-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.12 #170
Support Python 3.12 #170
Conversation
Unfortunately, there is an almost circular dependency with |
We're trying to support python 3.12 over on |
Sorry: I just interrupted because of other priorities. I thought no one needed py3.12 yet. I believe I could make it by today (if not before). It's non-trivial, but still relatively simple. |
The related PR in Qibo |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 12 12
Lines 1085 1085
=========================================
Hits 1085 1085
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@BrunoLiegiBastonLiegi @renatomello: apparently, there are issues linting the |
weird, may be some problem with the lock? |
The lock has no problem on its own, but you could inspect the locked Numba version. Lines 486 to 491 in 8cfaea4
|
Required for the quasi-circular dependency
Despite previously undeclared upper bounds, Numba suppports py3.12 only since 0.59 - i.e. since one month...
Finally compatible with py3.12
Just waiting for qiboteam/qibo#1231 to be merged |
@BrunoLiegiBastonLiegi @renatomello now that qiboteam/qibo#1231 has been merged, we should be ready to merge this as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alecandido, I am probably not the most indicated person to look into this, but to me this is ready. Just a note on the numba
and pylint
version, the earliest version we support is changing because python-3.12
does not support older versions?
Exactly :) (Though it is better said the other way round: older versions are not supporting py3.12, because of the dependency arrow) |
Thanks! @stavros11 @BrunoLiegiBastonLiegi |
@natestemen now both Qibo and Qibojit are supporting py3.12 in |
Unfortunately work-in-progress