Support Python 3.12 #1231

alecandido · 2024-02-28T06:29:01Z

No description provided.

alecandido · 2024-02-28T06:44:44Z

@natestemen this branch could work (in principle), and we've been kind of lucky: TensorFlow didn't support py3.12 until 5 days ago, when they published a release candidate with initial support (not yet a stable one).

I wonder whether it's this the triggered your update.

I still have to solve part of the problem with the installation, but the dependencies should now be alright.

alecandido · 2024-02-28T07:06:11Z

@scarrazza is it acceptable to have a TensorFlow release candidate dep in master?

alecandido · 2024-02-28T07:10:03Z

Assuming that tests are passing, the plan is the following:

merge Qibo py3.12 in master, with Qibojit branch dep
update Qibojit to Qibo master
merge Qibojit py3.12 in main, with Qibo master dep
update Qibo to Qibojit main
release Qibo, with Qibojit main (it is only a test dep, so it should be reasonable)
update Qibojit to Qibo release
release Qibojit
update Qibo to Qibojit release

alecandido · 2024-02-28T07:14:28Z

Tests are failing because hyperopt is a relatively old package (no release since two years) and it implicitly requires setuptools
https://github.com/hyperopt/hyperopt/tags
https://github.com/hyperopt/hyperopt/blob/d8515263a3168ba8f111179d29e74ffb09670610/setup.py#L46-L52
https://github.com/hyperopt/hyperopt/blob/d8515263a3168ba8f111179d29e74ffb09670610/hyperopt/atpe.py#L19

I'll try to circumvent the issue, but I'd recommend replacing it, if possible.

alecandido · 2024-02-28T10:09:38Z

Required for unitaryfund/mitiq#2066

alecandido · 2024-02-28T10:09:54Z

Currently stuck because of TensorFlow installation.

alecandido · 2024-02-28T10:13:48Z

Tests are passing, even though not doctests. The reason is that if tensorflow is not installed, the related tests are skipped:

qibo/tests/conftest.py

Lines 31 to 41 in aa0fab2

    
           # ignore backends that are not available in the current testing environment 
        
           AVAILABLE_BACKENDS = [] 
        
           MULTIGPU_BACKENDS = [] 
        
           for backend_name in BACKENDS: 
        
               try: 
        
                   _backend = get_backend(backend_name) 
        
                   AVAILABLE_BACKENDS.append(backend_name) 
        
                   if _backend.supports_multigpu:  # pragma: no cover 
        
                       MULTIGPU_BACKENDS.append(backend_name) 
        
               except (ModuleNotFoundError, ImportError): 
        
                   pass

stavros11 · 2024-03-01T12:33:55Z

Tests are passing, even though not doctests. The reason is that if tensorflow is not installed, the related tests are skipped:

Thanks @alecandido. This is expected, I think tests (not doctests) were set up so that they only run on backends that are available, mostly for convenience when running them locally in an environment with a subset of backends installed. However, I do not understand why tensorflow is not installed in the CI, since we still have it in the pyproject?

If tensorflow is the only issue blocking this I would consider disabling the related doctests temporarily and opening an issue until tensorflow is "officially" relased for py3.12. That also depends on what release we would like to include this. If I remember correctly is not for the one coming soon so maybe we could even keep on hold. The main motivation is that it is needed by an external project, though.

alecandido · 2024-03-01T19:22:45Z

However, I do not understand why tensorflow is not installed in the CI, since we still have it in the pyproject?

This is an issue with the release candidate package, most likely. That's why this PR is on hold, waiting for a more stable support for py3.12 from TensorFlow (or to make TensorFlow optional, e.g. outsourcing to qiboml).

alecandido · 2024-03-01T19:23:36Z

If tensorflow is the only issue blocking this I would consider disabling the related doctests temporarily and opening an issue until tensorflow is "officially" relased for py3.12. That also depends on what release we would like to include this. If I remember correctly is not for the one coming soon so maybe we could even keep on hold. The main motivation is that it is needed by an external project, though.

It's not too urgent, apparently, let's keep going with qibo-core and the reorganization first.

natestemen · 2024-03-02T02:51:47Z

Thank you for so much effort after I pinged y'all! Just want to say it's not super urgent on our side.

alecandido · 2024-03-02T06:51:27Z

Thank you for so much effort after I pinged y'all! Just want to say it's not super urgent on our side.

Thanks for the update @natestemen!
Indeed, I was initially a bit worried to be blocking mitiq, but now we're all waiting for TF.

I also checked the various common distributions, and no major one is shipping py3.12 as default Python yet.

In any case, we'll work on reducing the default dependencies later on, to make upgrades easier in general. For the time being, as soon as TF will be unlocked, we'll complete this PR.

renatomello · 2024-03-08T05:20:09Z

https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1

alecandido · 2024-03-11T22:47:45Z

https://github.com/tensorflow/tensorflow/releases/tag/v2.16.1

On PyPI since Saturday

I'll now make the package!

alecandido · 2024-03-11T23:38:08Z

Ok, now the situation is even more complicated, since the same problem of QiboJIT is now present for QiboTN as well.

I will move forward with this PR, and the matching ones
qiboteam/qibojit#170
qiboteam/qibotn#48

If tests are passing, we can merge. But we should try to push for qibo-core as well, otherwise this
#1231 (comment)
will get worse and worse.

alecandido · 2024-03-12T00:07:35Z

@BrunoLiegiBastonLiegi @renatomello, there is a Clifford test failing at random:
https://github.com/qiboteam/qibo/actions/runs/8241280424/job/22538218856#step:11:433

(as I wrote somewhere else, I expect that is because you're testing with random values, without fixing a seed - so tests are not reproducible; if you want fuzzying, consider using https://hypothesis.readthedocs.io/en/latest/ instead)

alecandido · 2024-03-12T00:19:46Z

And we have a problem with dtypes in Keras, generated by the QGAN tests
https://github.com/qiboteam/qibo/actions/runs/8241324205/job/22538355397?pr=1231#step:11:230

Funnily, the problem is on Linux, but not on Windows.

renatomello · 2024-03-12T05:10:33Z

@BrunoLiegiBastonLiegi @renatomello, there is a Clifford test failing at random: https://github.com/qiboteam/qibo/actions/runs/8241280424/job/22538218856#step:11:433

(as I wrote somewhere else, I expect that is because you're testing with random values, without fixing a seed - so tests are not reproducible; if you want fuzzying, consider using https://hypothesis.readthedocs.io/en/latest/ instead)

The fix is in #1202

alecandido · 2024-03-12T09:19:56Z

I guess it is edeff3a. I could cherry-pick it, but I'm not sure how many things I need from #1202.

renatomello · 2024-03-12T09:30:33Z

I guess it is edeff3a. I could cherry-pick it, but I'm not sure how many things I need from #1202.

#1202 is close to being merged into master. You could just merge master here when it happens, I guess.

In order to avoid the explicit CVXPY dependency

This time to avoid using tf.keras

I.e. remove explicit python version from nix, and remove the mention of CVXPY in qinfo extra, since the dependency is not there any longer

codecov · 2024-04-10T12:38:43Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (18c155a) to head (2dee381).
Report is 4 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1231      +/-   ##
==========================================
- Coverage   99.84%   99.83%   -0.01%     
==========================================
  Files          73       72       -1     
  Lines       10693    10484     -209     
==========================================
- Hits        10676    10467     -209     
  Misses         17       17

Flag	Coverage Δ
unittests	`99.83% <ø> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

alecandido · 2024-04-10T12:49:05Z

Ok, we just got the first Codecov report for this PR, since it's now passing on Ubuntu (still to be verified on Mac).

In the last commit we have been hit by the cache again*, but it should work in a while.

@stavros11 @scarrazza if you can take a look, and confirm that we're willing to accept the changes, we could merge as soon as the workflows will be passing.

*@scarrazza if you want a report with the cache error, here it is:
https://github.com/qiboteam/qibo/actions/runs/8631159207/attempts/1?pr=1231

stavros11

Thanks @alecandido. Other than the comments below, it looks good to me.

stavros11 · 2024-04-11T09:55:31Z

pyproject.toml

+qibojit = { git = "https://github.com/qiboteam/qibojit.git", branch = "py3.12" }
+qibotn = { git = "https://github.com/qiboteam/qibotn.git", branch = "py3.12" }


I guess these will be reverted to main later following #1231 (comment). Shall we open an issue before merging this or will we do immediately?

Not sure: unfortunately, that procedure should be followed from every incompatible update, so it could be worth an issue (at least for this time, but even to remember).

However, I'm working in parallel on qibo-core. If I'll manage to have something reasonable soon enough, we might not need anything like this any longer.

stavros11 · 2024-04-11T09:56:04Z

src/qibo/quantum_info/metrics.py

@@ -544,22 +546,20 @@ def diamond_norm(channel, target=None, backend=None, **kwargs):
    If a ``target`` channel :math:`\\Lambda` is specified,
    then it calculates :math:`\\| \\mathcal{E} - \\Lambda\\|_{\\diamond}`.

-    Example:
+    Example::


Suggested change

Example::

Example:

(is the double :: actually needed?)

The :: is an alias for code-block:: <default-language>

https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#literal-blocks

src/qibo/quantum_info/metrics.py

tests/test_quantum_info_metrics.py

Co-authored-by: Stavros Efthymiou <[email protected]>

src/qibo/quantum_info/metrics.py

alecandido mentioned this pull request Feb 28, 2024

Support Python 3.12 qiboteam/qibojit#170

Merged

alecandido requested review from scarrazza and stavros11 February 28, 2024 07:06

This was referenced Feb 28, 2024

Remove TensorFlow dependency qiboteam/qibocal#734

Closed

Replace hyperopt #1232

Closed

alecandido changed the title ~~Python 3.12 support~~ Support Python 3.12 Feb 28, 2024

alecandido force-pushed the py3.12 branch from aa0fab2 to 7499d07 Compare March 11, 2024 23:11

alecandido marked this pull request as ready for review March 12, 2024 00:10

renatomello assigned alecandido Mar 14, 2024

alecandido force-pushed the py3.12 branch from ad90bfb to 83cafab Compare March 14, 2024 07:59

alecandido added 3 commits April 10, 2024 12:01

chore: Poetry lock

f9d53c4

fix: Restore original complexes

c5fda23

feat!: Drop the QGAN model and related tests and docs

31a5a3e

alecandido force-pushed the py3.12 branch from c5ba8e7 to 31a5a3e Compare April 10, 2024 10:14

alecandido added 5 commits April 10, 2024 12:25

chore: Poetry lock

682d50b

docs: Downgrade example from doctest to just text

96a43bd

In order to avoid the explicit CVXPY dependency

docs: Downgrade further example to code block

9b6c04a

This time to avoid using tf.keras

chore: Polish environment files

aa151e8

I.e. remove explicit python version from nix, and remove the mention of CVXPY in qinfo extra, since the dependency is not there any longer

chore: Poetry lock

edd0b56

alecandido mentioned this pull request Apr 10, 2024

Suppport Python 3.12 qiboteam/qibotn#48

Merged

stavros11 approved these changes Apr 11, 2024

View reviewed changes

alecandido and others added 3 commits April 11, 2024 13:04

Update src/qibo/quantum_info/metrics.py

9d2fae5

Co-authored-by: Stavros Efthymiou <[email protected]>

fix: Partially restore autoformatted docstrings

02e737f

chore: Poetry lock

0006411

stavros11 mentioned this pull request Apr 12, 2024

CVXPY not available in Python 3.12 #1298

Open

alecandido mentioned this pull request Apr 15, 2024

build(deps): bump idna from 3.6 to 3.7 #1297

Closed

alecandido requested a review from renatomello April 19, 2024 16:57

renatomello reviewed Apr 22, 2024

View reviewed changes

src/qibo/quantum_info/metrics.py Show resolved Hide resolved

test: Exclude diamond norm from coverage

2dee381

alecandido requested a review from renatomello April 22, 2024 07:41

scarrazza approved these changes Apr 24, 2024

View reviewed changes

alecandido added this pull request to the merge queue Apr 24, 2024

Merged via the queue into master with commit a90c018 Apr 24, 2024
27 checks passed

alecandido deleted the py3.12 branch April 24, 2024 09:11

BrunoLiegiBastonLiegi mentioned this pull request Apr 26, 2024

CliffordBackend with packed bits #1239

Merged

4 tasks

alecandido mentioned this pull request Jul 15, 2024

Rename backend.issparse as backend.is_sparse qiboteam/qibojit#185

Merged

alecandido mentioned this pull request Oct 10, 2024

Support Python 3.13 #1484

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Python 3.12 #1231

Support Python 3.12 #1231

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

stavros11 commented Mar 1, 2024 •

edited

Loading

alecandido commented Mar 1, 2024

alecandido commented Mar 1, 2024

natestemen commented Mar 2, 2024

alecandido commented Mar 2, 2024

renatomello commented Mar 8, 2024

alecandido commented Mar 11, 2024

alecandido commented Mar 11, 2024 •

edited

Loading

alecandido commented Mar 12, 2024 •

edited

Loading

alecandido commented Mar 12, 2024

renatomello commented Mar 12, 2024

alecandido commented Mar 12, 2024

renatomello commented Mar 12, 2024

codecov bot commented Apr 10, 2024 •

edited

Loading

alecandido commented Apr 10, 2024 •

edited

Loading

stavros11 left a comment

stavros11 Apr 11, 2024

alecandido Apr 11, 2024

stavros11 Apr 11, 2024

alecandido Apr 11, 2024

		qibojit = { git = "https://github.com/qiboteam/qibojit.git", branch = "py3.12" }
		qibotn = { git = "https://github.com/qiboteam/qibotn.git", branch = "py3.12" }

Support Python 3.12 #1231

Support Python 3.12 #1231

Conversation

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

alecandido commented Feb 28, 2024

stavros11 commented Mar 1, 2024 • edited Loading

alecandido commented Mar 1, 2024

alecandido commented Mar 1, 2024

natestemen commented Mar 2, 2024

alecandido commented Mar 2, 2024

renatomello commented Mar 8, 2024

alecandido commented Mar 11, 2024

alecandido commented Mar 11, 2024 • edited Loading

alecandido commented Mar 12, 2024 • edited Loading

alecandido commented Mar 12, 2024

renatomello commented Mar 12, 2024

alecandido commented Mar 12, 2024

renatomello commented Mar 12, 2024

codecov bot commented Apr 10, 2024 • edited Loading

Codecov Report

alecandido commented Apr 10, 2024 • edited Loading

stavros11 left a comment

Choose a reason for hiding this comment

stavros11 Apr 11, 2024

Choose a reason for hiding this comment

alecandido Apr 11, 2024

Choose a reason for hiding this comment

stavros11 Apr 11, 2024

Choose a reason for hiding this comment

alecandido Apr 11, 2024

Choose a reason for hiding this comment

stavros11 commented Mar 1, 2024 •

edited

Loading

alecandido commented Mar 11, 2024 •

edited

Loading

alecandido commented Mar 12, 2024 •

edited

Loading

codecov bot commented Apr 10, 2024 •

edited

Loading

alecandido commented Apr 10, 2024 •

edited

Loading