Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1q emulator upgrades #985

Draft
wants to merge 16 commits into
base: 0.1
Choose a base branch
from
Draft

1q emulator upgrades #985

wants to merge 16 commits into from

Conversation

jykhoo1987
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Added function to construct emulator runcard from initialised (device) platform (less flux-related parameters)
Added function to estimate Rabi frequency
Added flux pulse emulation and default_q01_flux test emulator platform with iSWAP gate

@alecandido
Copy link
Member

alecandido commented Aug 15, 2024

@jykhoo1987 we are now working towards 0.2 release, by the end of this month. Thus, we're not going to accept any new submission to 0.1, but very urgent bugfixes.

You can continue working here, until 0.2 won't be more stable (hopefully next week, you can track progresses at https://github.com/qiboteam/qibolab/milestone/12). At which point, you will be advised to rebase your PR on https://github.com/qiboteam/qibolab/tree/0.2

(first thing to be done will be upgrading the driver for the changes, since they will be many)

@alecandido alecandido marked this pull request as draft August 15, 2024 15:42
@jykhoo1987
Copy link
Contributor Author

Ok noted. In that case should I close the pull request but keep this branch open? Basically the most updated stable version of the emulator in qibolab 0.1 will be found in this branch for anyone interested to use and test until it is rebased to 0.2, which might take a while.
An important requirement is, based on our conclusion from previous discussions or in the last weekly meeting, the qibocal update that is compatible with qibolab 0.2. Is there a timeline for when that will be released?

@alecandido
Copy link
Member

Ok noted. In that case should I close the pull request but keep this branch open? Basically the most updated stable version of the emulator in qibolab 0.1 will be found in this branch for anyone interested to use and test until it is rebased to 0.2, which might take a while.

No need, just keep this for the time being.

An important requirement is, based on our conclusion from previous discussions or in the last weekly meeting, the qibocal update that is compatible with qibolab 0.2. Is there a timeline for when that will be released?

I'd suggest opening a separate PR as soon as we will be sufficiently stable, and separately upgrading the existing features (only this PR requires the characterization section, not the emulator currently in Qibolab).
Then, this can be resumed when there will be a clearer plan for Qibocal as well (soon, no one would use Qibolab 0.2 without a compatible Qibocal).

It is possible to just rebase this PR. Or restart on top of the upgraded emulator. Which one will be simpler in practice will depend on how many changes you/we will apply during the upgrade.

@alecandido
Copy link
Member

In any case, you can continue working here for the time being. We will not merge immediately, but this doesn't mean that the PR will be lost at all.

@alecandido alecandido changed the base branch from main to 0.1 August 21, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants