-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1q emulator upgrades #985
base: 0.1
Are you sure you want to change the base?
1q emulator upgrades #985
Conversation
…1_flux, updated example notebook to showcase iSWAP gate
for more information, see https://pre-commit.ci
@jykhoo1987 we are now working towards 0.2 release, by the end of this month. Thus, we're not going to accept any new submission to 0.1, but very urgent bugfixes. You can continue working here, until 0.2 won't be more stable (hopefully next week, you can track progresses at https://github.com/qiboteam/qibolab/milestone/12). At which point, you will be advised to rebase your PR on https://github.com/qiboteam/qibolab/tree/0.2 (first thing to be done will be upgrading the driver for the changes, since they will be many) |
Ok noted. In that case should I close the pull request but keep this branch open? Basically the most updated stable version of the emulator in qibolab 0.1 will be found in this branch for anyone interested to use and test until it is rebased to 0.2, which might take a while. |
No need, just keep this for the time being.
I'd suggest opening a separate PR as soon as we will be sufficiently stable, and separately upgrading the existing features (only this PR requires the characterization section, not the emulator currently in Qibolab). It is possible to just rebase this PR. Or restart on top of the upgraded emulator. Which one will be simpler in practice will depend on how many changes you/we will apply during the upgrade. |
In any case, you can continue working here for the time being. We will not merge immediately, but this doesn't mean that the PR will be lost at all. |
…ed unused line in models/general_no_coupler_model.py
…model.py and pulse_simulator.py
…ls in QutipSimulator
for more information, see https://pre-commit.ci
Checklist:
Added function to construct emulator runcard from initialised (device) platform (less flux-related parameters)
Added function to estimate Rabi frequency
Added flux pulse emulation and default_q01_flux test emulator platform with iSWAP gate